* [RESEND] drbd: avoid clang warning about pointless switch statement
@ 2018-09-17 12:54 Philipp Klocke
0 siblings, 0 replies; only message in thread
From: Philipp Klocke @ 2018-09-17 12:54 UTC (permalink / raw)
To: philipp.reisner, lars.ellenberg, arnd
Cc: drbd-dev, nicolas.dichtel, davem, linux-kernel, lukas.bulwahn
The drbd code causes warnings that we cannot easily disable when
building with clang:
In file included from drivers/block/drbd/drbd_debugfs.c:10:
In file included from drivers/block/drbd/drbd_int.h:48:
In file included from include/linux/drbd_genl_api.h:53:
In file included from include/linux/genl_magic_struct.h:237:
include/linux/drbd_genl.h:300:1: warning: no case matching constant
switch condition '0'
There is nothing wrong with the code, and adding 'default:' labels
in the right place is enough to let clang shut up about the warning.
Fixes: ec2c35ac1ea2 ("drbd: prepare the transition from connector to
genetlink")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
--
was sent on Feb. 1, 2017, 4:55 p.m. UTC by Arnd Bergmann
was acked but not merged
resend
---
include/linux/genl_magic_struct.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/genl_magic_struct.h
b/include/linux/genl_magic_struct.h
index 6270a56e5edc..c6fbafb834f1 100644
--- a/include/linux/genl_magic_struct.h
+++ b/include/linux/genl_magic_struct.h
@@ -190,6 +190,7 @@ static inline void ct_assert_unique_operations(void)
{
switch (0) {
#include GENL_MAGIC_INCLUDE_FILE
+ default:
;
}
}
@@ -208,6 +209,7 @@ static inline void
ct_assert_unique_top_level_attributes(void)
{
switch (0) {
#include GENL_MAGIC_INCLUDE_FILE
+ default:
;
}
}
@@ -218,6 +220,7 @@ static inline void ct_assert_unique_ ## s_name ##
_attributes(void) \
{ \
switch (0) { \
s_fields \
+ default: \
; \
} \
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-09-17 12:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-17 12:54 [RESEND] drbd: avoid clang warning about pointless switch statement Philipp Klocke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®