mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Cc: David Ahern <dsahern@gmail.com>, Kan Liang <kan.liang@intel.com>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] perf stat: Fix duplicate error messages in perf_stat_synthesize_config()
Date: Mon, 20 Nov 2017 16:30:13 +0100	[thread overview]
Message-ID: <50004e9c-14f8-5a01-fa96-001d32e7c2b2@users.sourceforge.net> (raw)

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 20 Nov 2017 15:55:25 +0100

Duplicate error messages were used so far in this function implementation.
Make them unique instead.

This issue was detected by using the Coccinelle software.

Fixes: 7b60a7e3a687481553d2b6ec7e6390a6e82f1849 ("perf stat record: Synthesize event update events")
Fixes: 8b99b1a4e0b082ea6a277766982dac84483d4d3c ("perf stat record: Synthesize stat record data")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 tools/perf/builtin-stat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 59af5a8419e2..ed0f23bb2230 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -512,7 +512,7 @@ static int perf_stat_synthesize_config(bool is_pipe)
 		if (counter->own_cpus) {
 			err = perf_event__synthesize_event_update_cpus(NULL, counter, process_synthesized_event);
 			if (err < 0) {
-				pr_err("Couldn't synthesize evsel scale.\n");
+				pr_err("Couldn't synthesize evsel CPUs.\n");
 				return err;
 			}
 		}
@@ -541,7 +541,7 @@ static int perf_stat_synthesize_config(bool is_pipe)
 	err = perf_event__synthesize_cpu_map(NULL, evsel_list->cpus,
 					     process_synthesized_event, NULL);
 	if (err < 0) {
-		pr_err("Couldn't synthesize thread map.\n");
+		pr_err("Couldn't synthesize CPU map.\n");
 		return err;
 	}
 
-- 
2.15.0

             reply	other threads:[~2017-11-20 15:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 15:30 SF Markus Elfring [this message]
2017-11-20 15:46 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50004e9c-14f8-5a01-fa96-001d32e7c2b2@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome