mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Feng Kan <fkan@apm.com>,
	tj@kernel.org
Cc: patches@apm.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH RESEND] sata: xgene: add ACPI support for APM X-Gene SATA ports
Date: Thu, 19 Mar 2015 12:32:33 +0100	[thread overview]
Message-ID: <5003912.K8jaqGYKiW@vostro.rjw.lan> (raw)
In-Reply-To: <20150319095850.GO2165@lahna.fi.intel.com>

On Thursday, March 19, 2015 11:58:50 AM Mika Westerberg wrote:
> On Wed, Mar 18, 2015 at 05:03:55PM -0700, Feng Kan wrote:
> > This adds ACPI support for the APM X-Gene SATA ports. When the system
> > boots using ACPI table, the SATA ports are able to configure using the
> > values supplied by the ACPI table rather than the DTS.
> > 
> > Signed-off-by: Feng Kan <fkan@apm.com>
> > Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
> 
> One minor comment, see below. Other than that this looks good to me:
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thanks Mika!

So for the patch

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> > ---
> >  drivers/ata/ahci_xgene.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
> > index 2e8bb60..2b78510 100644
> > --- a/drivers/ata/ahci_xgene.c
> > +++ b/drivers/ata/ahci_xgene.c
> > @@ -22,6 +22,7 @@
> >   * NOTE: PM support is not currently available.
> >   *
> >   */
> > +#include <linux/acpi.h>
> >  #include <linux/module.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/ahci_platform.h>
> > @@ -718,6 +719,14 @@ disable_resources:
> >  	return rc;
> >  }
> >  
> > +#ifdef CONFIG_ACPI
> > +static const struct acpi_device_id xgene_ahci_acpi_match[] = {
> > +	{ "APMC0D0D", },
> 
> I think writing the above without comma would look better:
> 
> 	{ "APMC0D0D" },
> 
> 
> > +	{ }
> > +};
> > +MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
> > +#endif
> > +
> >  static const struct of_device_id xgene_ahci_of_match[] = {
> >  	{.compatible = "apm,xgene-ahci"},
> >  	{},
> > @@ -730,6 +739,7 @@ static struct platform_driver xgene_ahci_driver = {
> >  	.driver = {
> >  		.name = DRV_NAME,
> >  		.of_match_table = xgene_ahci_of_match,
> > +		.acpi_match_table = ACPI_PTR(xgene_ahci_acpi_match),
> >  	},
> >  };
> >  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2015-03-19 11:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19  0:03 Feng Kan
2015-03-19  9:58 ` Mika Westerberg
2015-03-19 11:32   ` Rafael J. Wysocki [this message]
2015-03-19 18:22 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5003912.K8jaqGYKiW@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=fkan@apm.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=patches@apm.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®