From: "H. Peter Anvin" <hpa@zytor.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@kernel.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] x86/build change for v3.6
Date: Wed, 25 Jul 2012 13:18:06 -0700 [thread overview]
Message-ID: <5010547E.2090404@zytor.com> (raw)
In-Reply-To: <20120725201511.GA888@merkur.ravnborg.org>
On 07/25/2012 01:15 PM, Sam Ravnborg wrote:
>
> This is not as expected....
> In this silly example it is maybe obvious but I have lost hours tracking
> down bugs due to this.
> You add a new target and suddenly someting unrelated breaks.
>
> What happens is that make consider the assignment a command due to the leading
> tab - and because is follows a target (or other commands).
>
> I hope this makes it clear why many makefiles in the kernel uses tabs for indent.
>
This is also a good reason why not to indent assignments in Makefiles by
full tab stops. A smaller indent can't be scrambled this way.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-07-25 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 13:44 Ingo Molnar
2012-07-22 13:58 ` Kirill A. Shutemov
2012-07-22 14:22 ` Ingo Molnar
2012-07-23 9:35 ` Kirill A. Shutemov
2012-07-25 20:15 ` Sam Ravnborg
2012-07-25 20:18 ` H. Peter Anvin [this message]
2012-07-26 6:55 ` Ingo Molnar
2012-07-29 20:42 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5010547E.2090404@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome