mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] staging: rtl8192e: Rename TSSI_13dBm, Pwr_Track and NumTotalRFPath
Date: Sun, 8 Jan 2023 15:09:40 +0100	[thread overview]
Message-ID: <50111a6f-08de-1da8-0deb-50b0e7a172b7@gmail.com> (raw)
In-Reply-To: <Y7Pni7tvFPhcz7bu@kadam>

On 1/3/23 09:30, Dan Carpenter wrote:
> On Thu, Dec 29, 2022 at 05:25:46PM +0100, Philipp Hortmann wrote:
>> Rename variable TSSI_13dBm to tssi_13dbm
> 
> I would probably have kept this one as-is.  It's not CamelCase, it's the
> correct way to capitalize it.
> 
> regards,
> dan carpenter
> 

Hi Dan,

sorry for late.

No issue with keeping this variable as is. But can you tell me the rule 
for the rest of the variables in this driver?

Here just some examples: (I know that checkpatch is not always right)
CHECK: Avoid CamelCase: <Avg_TSSI_Meas>
CHECK: Avoid CamelCase: <TSSI_13dBm>
CHECK: Avoid CamelCase: <Avg_TSSI_Meas_from_driver>

Are those OK as well?

I would like to do it the right way. I do not want to discuss every 
variable change.

Thanks for your support.

Bye Philipp

  reply	other threads:[~2023-01-08 14:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 16:25 [PATCH 0/7] staging: rtl8192e: Rename variables from r8192_priv start with ChannelPlan Philipp Hortmann
2022-12-29 16:25 ` [PATCH 1/7] staging: rtl8192e: Rename ChannelPlan, eeprom_ChannelPlan and CckPwEnl Philipp Hortmann
2022-12-29 16:25 ` [PATCH 2/7] staging: rtl8192e: Rename TSSI_13dBm, Pwr_Track and NumTotalRFPath Philipp Hortmann
2023-01-03  8:30   ` Dan Carpenter
2023-01-08 14:09     ` Philipp Hortmann [this message]
2023-01-09 12:53       ` Dan Carpenter
2022-12-29 16:25 ` [PATCH 3/7] staging: rtl8192e: Rename CCKPresentAtt Philipp Hortmann
2022-12-29 16:26 ` [PATCH 4/7] staging: rtl8192e: Rename TxPowerLevelCCK Philipp Hortmann
2022-12-29 16:26 ` [PATCH 5/7] staging: rtl8192e: Rename TxPowerLevelOFDM24G Philipp Hortmann
2022-12-29 16:26 ` [PATCH 6/7] staging: rtl8192e: Rename MCSTxPowerL.., LegacyHTTxPowe.. and AntennaTx Philipp Hortmann
2022-12-29 16:26 ` [PATCH 7/7] staging: rtl8192e: Rename SetRFPowerSta.., RfReg0Value and bTXPowerDa Philipp Hortmann
2022-12-29 16:32 ` [PATCH 0/7] staging: rtl8192e: Rename variables from r8192_priv start with ChannelPlan Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50111a6f-08de-1da8-0deb-50b0e7a172b7@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®