mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 8/8] vhost_net: use lockless peeking for skb array during busy polling
Date: Thu, 30 Mar 2017 11:53:15 +0800	[thread overview]
Message-ID: <50124a4d-ff2c-95cf-58c6-fdfc55747c0f@redhat.com> (raw)
In-Reply-To: <20170330053315-mutt-send-email-mst@kernel.org>



On 2017年03月30日 10:33, Michael S. Tsirkin wrote:
> On Thu, Mar 30, 2017 at 10:16:15AM +0800, Jason Wang wrote:
>>
>> On 2017年03月29日 20:07, Michael S. Tsirkin wrote:
>>> On Tue, Mar 21, 2017 at 12:04:47PM +0800, Jason Wang wrote:
>>>> For the socket that exports its skb array, we can use lockless polling
>>>> to avoid touching spinlock during busy polling.
>>>>
>>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>>> ---
>>>>    drivers/vhost/net.c | 7 +++++--
>>>>    1 file changed, 5 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
>>>> index 53f09f2..41153a3 100644
>>>> --- a/drivers/vhost/net.c
>>>> +++ b/drivers/vhost/net.c
>>>> @@ -551,10 +551,13 @@ static int peek_head_len(struct vhost_net_virtqueue *rvq, struct sock *sk)
>>>>    	return len;
>>>>    }
>>>> -static int sk_has_rx_data(struct sock *sk)
>>>> +static int sk_has_rx_data(struct vhost_net_virtqueue *rvq, struct sock *sk)
>>>>    {
>>>>    	struct socket *sock = sk->sk_socket;
>>>> +	if (rvq->rx_array)
>>>> +		return !__skb_array_empty(rvq->rx_array);
>>>> +
>>>>    	if (sock->ops->peek_len)
>>>>    		return sock->ops->peek_len(sock);
>>> I don't see which patch adds __skb_array_empty.
>> This is not something new, it was introduced by ad69f35d1dc0a ("skb_array:
>> array based FIFO for skbs").
>>
>> Thanks
> Same comment about a compiler barrier applies then.

Ok, rethink about this, since skb_array could be resized, using lockless 
version seems wrong.

For the comment of using compiler barrier, caller 
(vhost_net_rx_peek_head_len) uses cpu_relax(). But I haven't figured out 
why a compiler barrier is needed here. Could you please explain?

Thanks

>
>>>> @@ -579,7 +582,7 @@ static int vhost_net_rx_peek_head_len(struct vhost_net *net,
>>>>    		endtime = busy_clock() + vq->busyloop_timeout;
>>>>    		while (vhost_can_busy_poll(&net->dev, endtime) &&
>>>> -		       !sk_has_rx_data(sk) &&
>>>> +		       !sk_has_rx_data(rvq, sk) &&
>>>>    		       vhost_vq_avail_empty(&net->dev, vq))
>>>>    			cpu_relax();
>>>> -- 
>>>> 2.7.4

      reply	other threads:[~2017-03-30  3:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  4:04 [PATCH net-next 0/8] vhost-net rx batching Jason Wang
2017-03-21  4:04 ` [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing Jason Wang
2017-03-21 10:25   ` Sergei Shtylyov
2017-03-22  3:16     ` Jason Wang
2017-03-22 13:43   ` Michael S. Tsirkin
2017-03-23  5:33     ` Jason Wang
2017-03-21  4:04 ` [PATCH net-next 2/8] skb_array: " Jason Wang
2017-03-21  4:04 ` [PATCH net-next 3/8] tun: export skb_array Jason Wang
2017-03-21  4:04 ` [PATCH net-next 4/8] tap: " Jason Wang
2017-03-21  4:04 ` [PATCH net-next 5/8] tun: support receiving skb through msg_control Jason Wang
2017-03-21  4:04 ` [PATCH net-next 6/8] tap: support receiving skb from msg_control Jason Wang
2017-03-21  4:04 ` [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Jason Wang
2017-03-22 14:16   ` Michael S. Tsirkin
2017-03-23  5:34     ` Jason Wang
2017-03-29  9:58       ` Jason Wang
2017-03-29 10:46         ` Pankaj Gupta
2017-03-29 10:53           ` Jason Wang
2017-03-29 21:47             ` Michael S. Tsirkin
2017-03-21  4:04 ` [PATCH net-next 8/8] vhost_net: use lockless peeking for skb array during busy polling Jason Wang
2017-03-29 12:07   ` Michael S. Tsirkin
2017-03-30  2:16     ` Jason Wang
2017-03-30  2:33       ` Michael S. Tsirkin
2017-03-30  3:53         ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50124a4d-ff2c-95cf-58c6-fdfc55747c0f@redhat.com \
    --to=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®