From: Dan Murphy <dmurphy@ti.com>
To: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <rpurdie@rpsys.net>,
<jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node
Date: Fri, 8 Dec 2017 09:56:18 -0600 [thread overview]
Message-ID: <50214549-63d1-f92e-d4e7-dc6533477d83@ti.com> (raw)
In-Reply-To: <20171208155514.7696-1-dmurphy@ti.com>
Resent to include DT maintainers
On 12/08/2017 09:55 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
>
> v2 - Moved compatible to be first in the node - https://patchwork.kernel.org/patch/10092937/
>
> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..fc7f5f9f234c 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,10 +59,10 @@ Example
> =======
>
> as3645a@30 {
Rob
Here is an example of the device name being part of the node name.
Should this be changed as well to leds@30?
Dan
> - #address-cells: 1
> - #size-cells: 0
> - reg = <0x30>;
> compatible = "ams,as3645a";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x30>;
> flash@0 {
> reg = <0x0>;
> flash-timeout-us = <150000>;
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2017-12-08 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 15:55 Dan Murphy
2017-12-08 15:56 ` Dan Murphy [this message]
2017-12-15 20:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50214549-63d1-f92e-d4e7-dc6533477d83@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®