From: Beleswar Prasad Padhi <b-padhi@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>, <nm@ti.com>, <vigneshr@ti.com>,
<kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>
Cc: <tony@atomide.com>, <g-vlaev@ti.com>, <afd@ti.com>,
<hnagalla@ti.com>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] arm64: dts: ti: k3-j7200: Change timer nodes status to reserved
Date: Fri, 16 Aug 2024 12:46:21 +0530 [thread overview]
Message-ID: <50277a8a-e08c-486f-98c3-870562a91c20@ti.com> (raw)
In-Reply-To: <8394ab04-5e5c-4e06-b1d1-7eb64bacedbe@ti.com>
Hi Udit,
On 14-08-2024 20:41, Kumar, Udit wrote:
>
> On 8/14/2024 4:11 PM, Beleswar Padhi wrote:
>> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
>
> There is no DSP on this SOC.
>
> Please consider to re-word commit message
Thanks for catching this! Will fix in revision.
>
>
>> use timers. Therefore, change the status of the timer nodes to
>> "reserved" to avoid any clash. Usage is described as below:
>>
>> +===================+==========================+
>> | Remoteproc node | Timer Node |
>> +===================+==========================+
>> | main_r5fss0_core0 | main_timer0, main_timer2 |
>> +-------------------+--------------------------+
>> | main_r5fss0_core1 | main_timer1 |
>> +-------------------+--------------------------+
>
>
>> This change is already incorporated for timer nodes in the MCU voltage
>> domain.
>
> For whole series, on MCU domain R5 we have device-manager firmware,
>
> which is needed to get SOC functional. So MCU domain timers are reserved.
Understood. Will fix in revision.
>
> So my suggestion will be to avoid above message
>
>
>>
>> Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose
>> timers")
>> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
>> ---
>> .../boot/dts/ti/k3-j7200-common-proc-board.dts | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index 6593c5da82c0..a65066bd7f09 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -471,3 +471,16 @@ &main_mcan3 {
>> pinctrl-0 = <&main_mcan3_pins_default>;
>> phys = <&transceiver3>;
>> };
>> +
>> +/* Timers are used by Remoteproc firmware */
>> +&main_timer0 {
>> + status = "reserved";
>> +};
>> +
>> +&main_timer1 {
>> + status = "reserved";
>> +};
>> +
>> +&main_timer2 {
>> + status = "reserved";
>> +};
next prev parent reply other threads:[~2024-08-16 7:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 10:41 [PATCH v2 0/5] Reserve Timer Nodes to avoid clash with Remoteproc Beleswar Padhi
2024-08-14 10:41 ` [PATCH v2 1/5] arm64: dts: ti: k3-j7200: Change timer nodes status to reserved Beleswar Padhi
2024-08-14 15:11 ` Kumar, Udit
2024-08-16 7:16 ` Beleswar Prasad Padhi [this message]
2024-08-14 10:41 ` [PATCH v2 2/5] arm64: dts: ti: k3-j721e: " Beleswar Padhi
2024-08-14 10:41 ` [PATCH v2 3/5] arm64: dts: ti: k3-j721s2: " Beleswar Padhi
2024-08-14 10:41 ` [PATCH v2 4/5] arm64: dts: ti: k3-j784s4: " Beleswar Padhi
2024-08-14 10:41 ` [PATCH v2 5/5] arm64: dts: ti: k3-j722s: " Beleswar Padhi
2024-08-14 15:56 ` Kumar, Udit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50277a8a-e08c-486f-98c3-870562a91c20@ti.com \
--to=b-padhi@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=g-vlaev@ti.com \
--cc=hnagalla@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®