[PATCH v2 0/5] Reserve Timer Nodes to avoid clash with Remoteproc

[PATCH v2 0/5] Reserve Timer Nodes to avoid clash with Remoteproc

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. At the same time, if Linux probes the timers, some
instability is observed while booting remote cores. Therefore, change
the status of the timer nodes to "reserved" to avoid any clash. 

This change is already incorporated for timer nodes in the MCU voltage
domain.

v2: Changelog:
- Split the changes into individual patches for each SoC to tag the
  correct offending commit for "Fixes:" tag.

* Udit
1) Add the correct clashing timer nodes for J7200 SoC.
2) Port these changes to board level dts files instead of SoC level dtsi files.

Link to v1:
https://lore.kernel.org/all/20240607105559.771080-1-b-padhi@ti.com/

Beleswar Padhi (5):
  arm64: dts: ti: k3-j7200: Change timer nodes status to reserved
  arm64: dts: ti: k3-j721e: Change timer nodes status to reserved
  arm64: dts: ti: k3-j721s2: Change timer nodes status to reserved
  arm64: dts: ti: k3-j784s4: Change timer nodes status to reserved
  arm64: dts: ti: k3-j722s: Change timer nodes status to reserved

 .../dts/ti/k3-j7200-common-proc-board.dts     | 13 ++++++
 .../dts/ti/k3-j721e-common-proc-board.dts     | 29 +++++++++++++
 .../dts/ti/k3-j721s2-common-proc-board.dts    | 25 +++++++++++
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts       | 13 ++++++
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts      | 41 +++++++++++++++++++
 5 files changed, 121 insertions(+)

-- 
2.34.1

[PATCH v2 1/5] arm64: dts: ti: k3-j7200: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+==========================+
	|  Remoteproc node  |        Timer Node        |
	+===================+==========================+
	| main_r5fss0_core0 | main_timer0, main_timer2 |
	+-------------------+--------------------------+
	| main_r5fss0_core1 | main_timer1              |
	+-------------------+--------------------------+

This change is already incorporated for timer nodes in the MCU voltage
domain.

Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 .../boot/dts/ti/k3-j7200-common-proc-board.dts      | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index 6593c5da82c0..a65066bd7f09 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -471,3 +471,16 @@ &main_mcan3 {
 	pinctrl-0 = <&main_mcan3_pins_default>;
 	phys = <&transceiver3>;
 };
+
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
-- 
2.34.1

[PATCH v2 2/5] arm64: dts: ti: k3-j721e: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+==============+
	|  Remoteproc node  |  Timer Node  |
	+===================+==============+
	| main_r5fss0_core0 | main_timer12 |
	+-------------------+--------------+
	| main_r5fss0_core1 | main_timer13 |
	+-------------------+--------------+
	| main_r5fss1_core0 | main_timer14 |
	+-------------------+--------------+
	| main_r5fss1_core1 | main_timer15 |
	+-------------------+--------------+
	| c66_0             | main_timer0  |
	+-------------------+--------------+
	| c66_1             | main_timer1  |
	+-------------------+--------------+
	| c71_0             | main_timer2  |
	+-------------------+--------------+

This change is already incorporated for timer nodes in the MCU voltage
domain.

Fixes: 7f209dd1267c ("arm64: dts: ti: k3-j721e: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 .../dts/ti/k3-j721e-common-proc-board.dts     | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 8230d53cd696..d7969122afd8 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -974,3 +974,32 @@ &main_mcan2 {
 	pinctrl-0 = <&main_mcan2_pins_default>;
 	phys = <&transceiver4>;
 };
+
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer12 {
+	status = "reserved";
+};
+
+&main_timer13 {
+	status = "reserved";
+};
+
+&main_timer14 {
+	status = "reserved";
+};
+
+&main_timer15 {
+	status = "reserved";
+};
-- 
2.34.1

[PATCH v2 3/5] arm64: dts: ti: k3-j721s2: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer2 |
	+-------------------+-------------+
	| main_r5fss0_core1 | main_timer3 |
	+-------------------+-------------+
	| main_r5fss1_core0 | main_timer4 |
	+-------------------+-------------+
	| main_r5fss1_core1 | main_timer5 |
	+-------------------+-------------+
	| c71_0             | main_timer0 |
	+-------------------+-------------+
	| c71_1             | main_timer1 |
	+-------------------+-------------+

This change is already incorporated for timer nodes in the MCU voltage
domain.

Fixes: 835d04422f9d ("arm64: dts: ti: k3-j721s2: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 .../dts/ti/k3-j721s2-common-proc-board.dts    | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
index c5a0b7cbb14f..2903e15b8d3b 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
@@ -525,3 +525,28 @@ &main_mcan5 {
 	pinctrl-0 = <&main_mcan5_pins_default>;
 	phys = <&transceiver4>;
 };
+
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer3 {
+	status = "reserved";
+};
+
+&main_timer4 {
+	status = "reserved";
+};
+
+&main_timer5 {
+	status = "reserved";
+};
-- 
2.34.1

[PATCH v2 4/5] arm64: dts: ti: k3-j784s4: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer4 |
	+-------------------+-------------+
	| main_r5fss0_core1 | main_timer5 |
	+-------------------+-------------+
	| main_r5fss1_core0 | main_timer6 |
	+-------------------+-------------+
	| main_r5fss1_core1 | main_timer7 |
	+-------------------+-------------+
	| main_r5fss2_core0 | main_timer8 |
	+-------------------+-------------+
	| main_r5fss2_core1 | main_timer9 |
	+-------------------+-------------+
	| c71_0             | main_timer0 |
	+-------------------+-------------+
	| c71_1             | main_timer1 |
	+-------------------+-------------+
	| c71_2             | main_timer2 |
	+-------------------+-------------+
	| c71_3             | main_timer3 |
	+-------------------+-------------+

This change is already incorporated for timer nodes in the MCU voltage
domain.

Fixes: 833377cf858b ("arm64: dts: ti: k3-j784s4: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 41 ++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index ffa38f41679d..5e8bea3a5d82 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -1050,6 +1050,47 @@ &main_cpsw1_port1 {
 	status = "okay";
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer3 {
+	status = "reserved";
+};
+
+&main_timer4 {
+	status = "reserved";
+};
+
+&main_timer5 {
+	status = "reserved";
+};
+
+&main_timer6 {
+	status = "reserved";
+};
+
+&main_timer7 {
+	status = "reserved";
+};
+
+&main_timer8 {
+	status = "reserved";
+};
+
+&main_timer9 {
+	status = "reserved";
+};
+
 &mailbox0_cluster0 {
 	status = "okay";
 	interrupts = <436>;
-- 
2.34.1

[PATCH v2 5/5] arm64: dts: ti: k3-j722s: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc Node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer0 |
	+-------------------+-------------+
	| c7x_0             | main_timer1 |
	+-------------------+-------------+
	| c7x_1             | main_timer2 |
	+-------------------+-------------+

This change is already incorporated for timer nodes in the MCU voltage
domain.

Fixes: 3308a31c507c ("arm64: dts: ti: k3-am62: Add general purpose timers for am62")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index dd3b5f7039d7..e03beb0b5aad 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -566,3 +566,16 @@ &mcasp1 {
 	       0 0 0 0
 	>;
 };
+
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
-- 
2.34.1

Re: [PATCH v2 1/5] arm64: dts: ti: k3-j7200: Change timer nodes status to reserved

[Kumar, Udit]

On 8/14/2024 4:11 PM, Beleswar Padhi wrote:
> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain

There is no DSP on this SOC.

Please consider to re-word commit message


> use timers. Therefore, change the status of the timer nodes to
> "reserved" to avoid any clash. Usage is described as below:
>
> 	+===================+==========================+
> 	|  Remoteproc node  |        Timer Node        |
> 	+===================+==========================+
> 	| main_r5fss0_core0 | main_timer0, main_timer2 |
> 	+-------------------+--------------------------+
> 	| main_r5fss0_core1 | main_timer1              |
> 	+-------------------+--------------------------+


> This change is already incorporated for timer nodes in the MCU voltage
> domain.

For whole series,  on MCU domain R5 we have device-manager firmware,

which is needed to get SOC functional. So MCU domain timers are reserved.

So my suggestion will be to avoid above message


>
> Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers")
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> ---
>   .../boot/dts/ti/k3-j7200-common-proc-board.dts      | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> index 6593c5da82c0..a65066bd7f09 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> @@ -471,3 +471,16 @@ &main_mcan3 {
>   	pinctrl-0 = <&main_mcan3_pins_default>;
>   	phys = <&transceiver3>;
>   };
> +
> +/* Timers are used by Remoteproc firmware */
> +&main_timer0 {
> +	status = "reserved";
> +};
> +
> +&main_timer1 {
> +	status = "reserved";
> +};
> +
> +&main_timer2 {
> +	status = "reserved";
> +};

Re: [PATCH v2 5/5] arm64: dts: ti: k3-j722s: Change timer nodes status to reserved

[Kumar, Udit]

On 8/14/2024 4:11 PM, Beleswar Padhi wrote:
> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
> use timers. Therefore, change the status of the timer nodes to
> "reserved" to avoid any clash. Usage is described as below:
>
> 	+===================+=============+
> 	|  Remoteproc Node  | Timer Node  |
> 	+===================+=============+
> 	| main_r5fss0_core0 | main_timer0 |
> 	+-------------------+-------------+
> 	| c7x_0             | main_timer1 |
> 	+-------------------+-------------+
> 	| c7x_1             | main_timer2 |
> 	+-------------------+-------------+
>
> This change is already incorporated for timer nodes in the MCU voltage
> domain.
>
> Fixes: 3308a31c507c ("arm64: dts: ti: k3-am62: Add general purpose timers for am62")

Please check Fixes tag once.

AFAIR, J722S uses am62p not am62


> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index dd3b5f7039d7..e03beb0b5aad 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -566,3 +566,16 @@ &mcasp1 {
>   	       0 0 0 0
>   	>;
>   };
> +
> +/* Timers are used by Remoteproc firmware */
> +&main_timer0 {
> +	status = "reserved";
> +};
> +
> +&main_timer1 {
> +	status = "reserved";
> +};
> +
> +&main_timer2 {
> +	status = "reserved";
> +};

Re: [PATCH v2 1/5] arm64: dts: ti: k3-j7200: Change timer nodes status to reserved

[Beleswar Prasad Padhi]

Hi Udit,

On 14-08-2024 20:41, Kumar, Udit wrote:
>
> On 8/14/2024 4:11 PM, Beleswar Padhi wrote:
>> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
>
> There is no DSP on this SOC.
>
> Please consider to re-word commit message


Thanks for catching this! Will fix in revision.

>
>
>> use timers. Therefore, change the status of the timer nodes to
>> "reserved" to avoid any clash. Usage is described as below:
>>
>>     +===================+==========================+
>>     |  Remoteproc node  |        Timer Node        |
>>     +===================+==========================+
>>     | main_r5fss0_core0 | main_timer0, main_timer2 |
>>     +-------------------+--------------------------+
>>     | main_r5fss0_core1 | main_timer1              |
>>     +-------------------+--------------------------+
>
>
>> This change is already incorporated for timer nodes in the MCU voltage
>> domain.
>
> For whole series,  on MCU domain R5 we have device-manager firmware,
>
> which is needed to get SOC functional. So MCU domain timers are reserved.


Understood. Will fix in revision.

>
> So my suggestion will be to avoid above message
>
>
>>
>> Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose 
>> timers")
>> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
>> ---
>>   .../boot/dts/ti/k3-j7200-common-proc-board.dts      | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts 
>> b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index 6593c5da82c0..a65066bd7f09 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -471,3 +471,16 @@ &main_mcan3 {
>>       pinctrl-0 = <&main_mcan3_pins_default>;
>>       phys = <&transceiver3>;
>>   };
>> +
>> +/* Timers are used by Remoteproc firmware */
>> +&main_timer0 {
>> +    status = "reserved";
>> +};
>> +
>> +&main_timer1 {
>> +    status = "reserved";
>> +};
>> +
>> +&main_timer2 {
>> +    status = "reserved";
>> +};