From: Bernhard Froemel <froemel@vmars.tuwien.ac.at>
To: Matthew Garrett <mjg@redhat.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware
Date: Tue, 14 Aug 2012 16:05:52 +0200 [thread overview]
Message-ID: <502A5B40.9010303@vmars.tuwien.ac.at> (raw)
In-Reply-To: <20120814004625.GB18992@thinkpad-t410>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Please reduce the delay in the gmux_index_wait_[ready|complete]
functions: 100ms is way too long. 1 ms is more than enough. I never
experienced any problems with 100 us.
The version information can also be extracted in the new gmux device
(see my initial patch proposal).
Bernhard
On 08/14/2012 02:46 AM, Seth Forshee wrote:
> On Mon, Aug 13, 2012 at 06:52:49PM -0400, Matthew Garrett wrote:
>> New gmux devices have a different method for accessing the
>> registers. Update the driver to cope. Incorporates feedback from
>> Bernhard Froemel.
>>
>> Signed-off-by: Matthew Garrett <mjg@redhat.com> Cc: Bernhard
>> Froemel <froemel@vmars.tuwien.ac.at> Cc: Seth Forshee
>> <seth.forshee@canonical.com>
>
> Acked-by: Seth Forshee <seth.forshee@canonical.com>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlAqWz8ACgkQ6iVUjPs37Jny4QCgvIj24lw/hpSF35P3k7vKcxtt
xj4AoNdN4u1QE4YErj771aP2ArZMDOS1
=TJHi
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-08-14 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 22:52 [PATCH V2 1/2] gmux: Add generic write32 function Matthew Garrett
2012-08-13 22:52 ` [PATCH V2 2/2] apple_gmux: Add support for newer hardware Matthew Garrett
2012-08-14 0:46 ` Seth Forshee
2012-08-14 14:05 ` Bernhard Froemel [this message]
2012-08-14 14:53 ` Bernhard Froemel
2012-08-14 15:15 ` Seth Forshee
2012-08-14 17:11 ` Bernhard Froemel
2012-08-15 7:46 ` Bernhard Froemel
2012-08-14 0:44 ` [PATCH V2 1/2] gmux: Add generic write32 function Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A5B40.9010303@vmars.tuwien.ac.at \
--to=froemel@vmars.tuwien.ac.at \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®