From: Bernhard Froemel <froemel@vmars.tuwien.ac.at>
To: Matthew Garrett <mjg@redhat.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware
Date: Wed, 15 Aug 2012 09:46:31 +0200 [thread overview]
Message-ID: <502B53D7.8080804@vmars.tuwien.ac.at> (raw)
In-Reply-To: <502A86B7.8010402@vmars.tuwien.ac.at>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/14/2012 07:11 PM, Bernhard Froemel wrote:
> Need to play around further..
I think I solved the communication problems concerning byte writes to
the gmux device.
This:
http://luna.vmars.tuwien.ac.at/~froemel/rmbp/patch-apple-gmux_v2.txt
works reliable for me (50+ suspend/resume cycles, many brightness
changes) *without* delays.
I looked once more through Apple's original driver and noticed that
their cmd_done waits until bit 1 is set (not cleared!) and also does
the final read from GMUX_PORT_DPM_RADDR only if bit 1 is not set.
Also it seems that in case of byte writes the old interface should be
followed as well (Apple, why?!).
Bernhard
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlArU9cACgkQ6iVUjPs37Jk6iACfWuZ7zpbc1vFLgJR29UroJeL2
HvMAnja8D7/o+aqywr/qRtNrB/o217Ci
=gcjo
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-08-15 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 22:52 [PATCH V2 1/2] gmux: Add generic write32 function Matthew Garrett
2012-08-13 22:52 ` [PATCH V2 2/2] apple_gmux: Add support for newer hardware Matthew Garrett
2012-08-14 0:46 ` Seth Forshee
2012-08-14 14:05 ` Bernhard Froemel
2012-08-14 14:53 ` Bernhard Froemel
2012-08-14 15:15 ` Seth Forshee
2012-08-14 17:11 ` Bernhard Froemel
2012-08-15 7:46 ` Bernhard Froemel [this message]
2012-08-14 0:44 ` [PATCH V2 1/2] gmux: Add generic write32 function Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502B53D7.8080804@vmars.tuwien.ac.at \
--to=froemel@vmars.tuwien.ac.at \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome