Re: [PATCH]:dir.c patch

[Bernd Schubert <bernd.schubert@fastmail.fm>]

On 08/25/2012 10:37 PM, Christopher Sacchi wrote:
> Here is a non-style issue dir.c-patch, and as far as I can see from
> the lines of code, the compilation errors weren't about what I put in.
> This patch fixes a "break" statement inside an "if" statement, as
> obviously not correct.

Why should that not be correct? It breaks the while(1) loop?

> Here's the patch for the kernel version v3.6.0rc3:
> 
> --
> Signed-off-by: Christopher P. Sacchi <chris.sacchi@gmail.com>
> --- dir.c	2012-08-25 15:47:24.260443900 -0400
> +++ dir.c	2012-08-25 16:02:05.458845600 -0400
> @@ -580,7 +580,6 @@ static int ext4_dx_readdir(struct file *
>  				return ret;
>  			if (ret == 0) {
>  				filp->f_pos = ext4_get_htree_eof(filp);
> -				break;

So ext4_htree_fill_tree() did not return more entries and the while(1)
loop shall be stopped?


Cheers,
Bernd