* [PATCH]:dir.c patch
@ 2012-08-25 20:37 Christopher Sacchi
2012-08-25 21:36 ` Bernd Schubert
0 siblings, 1 reply; 2+ messages in thread
From: Christopher Sacchi @ 2012-08-25 20:37 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Linux Kernel Mailing List
Here is a non-style issue dir.c-patch, and as far as I can see from
the lines of code, the compilation errors weren't about what I put in.
This patch fixes a "break" statement inside an "if" statement, as
obviously not correct.
Here's the patch for the kernel version v3.6.0rc3:
--
Signed-off-by: Christopher P. Sacchi <chris.sacchi@gmail.com>
--- dir.c 2012-08-25 15:47:24.260443900 -0400
+++ dir.c 2012-08-25 16:02:05.458845600 -0400
@@ -580,7 +580,6 @@ static int ext4_dx_readdir(struct file *
return ret;
if (ret == 0) {
filp->f_pos = ext4_get_htree_eof(filp);
- break;
}
info->curr_node = rb_first(&info->root);
}
--
--
Christopher
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH]:dir.c patch
2012-08-25 20:37 [PATCH]:dir.c patch Christopher Sacchi
@ 2012-08-25 21:36 ` Bernd Schubert
0 siblings, 0 replies; 2+ messages in thread
From: Bernd Schubert @ 2012-08-25 21:36 UTC (permalink / raw)
To: Christopher Sacchi; +Cc: linux-fsdevel, Linux Kernel Mailing List, linux-ext4
On 08/25/2012 10:37 PM, Christopher Sacchi wrote:
> Here is a non-style issue dir.c-patch, and as far as I can see from
> the lines of code, the compilation errors weren't about what I put in.
> This patch fixes a "break" statement inside an "if" statement, as
> obviously not correct.
Why should that not be correct? It breaks the while(1) loop?
> Here's the patch for the kernel version v3.6.0rc3:
>
> --
> Signed-off-by: Christopher P. Sacchi <chris.sacchi@gmail.com>
> --- dir.c 2012-08-25 15:47:24.260443900 -0400
> +++ dir.c 2012-08-25 16:02:05.458845600 -0400
> @@ -580,7 +580,6 @@ static int ext4_dx_readdir(struct file *
> return ret;
> if (ret == 0) {
> filp->f_pos = ext4_get_htree_eof(filp);
> - break;
So ext4_htree_fill_tree() did not return more entries and the while(1)
loop shall be stopped?
Cheers,
Bernd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-25 21:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-25 20:37 [PATCH]:dir.c patch Christopher Sacchi
2012-08-25 21:36 ` Bernd Schubert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome