From: Sohil Mehta <sohil.mehta@intel.com>
To: Maciej Wieczor-Retman <m.wieczorretman@pm.me>, <tglx@kernel.org>,
<bp@alien8.de>, <mingo@redhat.com>, <darwi@linutronix.de>,
<thuth@redhat.com>, <dave.hansen@linux.intel.com>,
<ak@linux.intel.com>, <babu.moger@amd.com>,
<chang.seok.bae@intel.com>, <peterz@infradead.org>,
<nik.borisov@suse.com>, <jpoimboe@kernel.org>,
<pawan.kumar.gupta@linux.intel.com>, <hpa@zytor.com>,
<xin@zytor.com>, <maciej.wieczor-retman@intel.com>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 2/3] x86/cpu: Check if feature string is non-zero
Date: Tue, 17 Mar 2026 13:29:44 -0700 [thread overview]
Message-ID: <5041430d-7915-488a-b102-67a30e7b4b07@intel.com> (raw)
In-Reply-To: <92b57f62940b1972d39ae270b1b1ea497462c9ec.1773771353.git.m.wieczorretman@pm.me>
On 3/17/2026 1:00 PM, Maciej Wieczor-Retman wrote:
> From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>
> In filter_cpuid_features(), x86_cap_flags[] is read, but it's not verified
> whether the string is non-zero which could lead to unwanted output.
>
> In two more places there are open coded paths that try to retrieve a
> feature string, and if there isn't one, the feature word and bit are
> returned instead.
>
> Add a common helper to fix filter_cpuid_features() as well as clean up
> the open coded cases.
>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---
Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
next prev parent reply other threads:[~2026-03-17 20:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 20:00 [PATCH v10 0/3] x86: Capability bits fix and required bits sanity check Maciej Wieczor-Retman
2026-03-17 20:00 ` [PATCH v10 1/3] x86/cpu: Clear feature bits disabled at compile-time Maciej Wieczor-Retman
2026-03-17 20:00 ` [PATCH v10 2/3] x86/cpu: Check if feature string is non-zero Maciej Wieczor-Retman
2026-03-17 20:29 ` Sohil Mehta [this message]
2026-03-18 23:41 ` Pawan Gupta
2026-03-19 17:18 ` Maciej Wieczor-Retman
2026-03-17 20:00 ` [PATCH v10 3/3] x86/cpu: Do a sanity check on required feature bits Maciej Wieczor-Retman
2026-03-17 20:43 ` Sohil Mehta
2026-03-18 10:08 ` Maciej Wieczor-Retman
2026-03-19 0:02 ` Pawan Gupta
2026-03-19 17:46 ` Maciej Wieczor-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5041430d-7915-488a-b102-67a30e7b4b07@intel.com \
--to=sohil.mehta@intel.com \
--cc=ak@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.wieczorretman@pm.me \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=thuth@redhat.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®