From: Stephen Warren <swarren@wwwdotorg.org>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>, "lrg@ti.com" <lrg@ti.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 4/4] regulator: tps65090: add external control support for DCDC
Date: Tue, 09 Oct 2012 10:21:05 -0600 [thread overview]
Message-ID: <50744EF1.6090609@wwwdotorg.org> (raw)
In-Reply-To: <D958900912E20642BCBC71664EFECE3E6DDF8AF6F1@BGMAIL02.nvidia.com>
On 10/09/2012 04:33 AM, Venu Byravarasu wrote:
> Laxman Dewangan wrote at Tuesday, October 09, 2012 3:19 PM:
>> The TPS65090's DCDC output can also be enable/disable through the
>> external digital input signal. Add support for enable/disable
>> either through register access via I2C or through external
>> control inputs. The external control inputs can be driven through
>> GPIOs also and hence adding support for passing the GPIO number.
>> -static struct regulator_ops tps65090_ops = {
>> - .enable = regulator_enable_regmap,
>> - .disable = regulator_disable_regmap,
>> - .is_enabled = regulator_is_enabled_regmap,
>> +static struct regulator_ops tps65090_ext_control_ops = {
>> +};
>
> What is the purpose of adding empty structure?
When replying to a patch (or email in general), it's usually a good idea
to delete stuff that you're not replying to. Otherwise, it can be hard
to find the replies since they're buried in a huge long email.
next prev parent reply other threads:[~2012-10-09 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 9:48 [PATCH V2 0/4] regulator: tps65090: fix regulator registration and add external control support Laxman Dewangan
2012-10-09 9:48 ` [PATCH V2 1/4] regulator; tps65090: Register all regulators in single probe call Laxman Dewangan
2012-10-09 9:49 ` [PATCH V2 2/4] regulator: tps65090: rename driver name and regulator name Laxman Dewangan
2012-10-09 9:49 ` [PATCH V2 3/4] regulator: tps65090: Add support for LDO regulators Laxman Dewangan
2012-10-09 9:49 ` [PATCH V2 4/4] regulator: tps65090: add external control support for DCDC Laxman Dewangan
2012-10-09 10:33 ` Venu Byravarasu
2012-10-09 10:02 ` Laxman Dewangan
2012-10-09 11:11 ` Venu Byravarasu
2012-10-09 11:13 ` Laxman Dewangan
2012-10-09 10:35 ` Mark Brown
2012-10-09 16:21 ` Stephen Warren [this message]
2012-10-17 13:21 ` [PATCH V2 0/4] regulator: tps65090: fix regulator registration and add external control support Mark Brown
2012-10-17 13:33 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50744EF1.6090609@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome