From: Quentin Monnet <qmo@kernel.org>
To: Tao Chen <chen.dylane@linux.dev>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, davem@davemloft.net, kuba@kernel.org,
hawk@kernel.org
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 3/3] bpftool: Add bash completion for token argument
Date: Tue, 22 Jul 2025 17:37:40 +0100 [thread overview]
Message-ID: <50872d17-fd8a-4f84-826b-62c08c7d304a@kernel.org> (raw)
In-Reply-To: <5681662e-6038-433f-9da7-438b383621b7@linux.dev>
2025-07-23 00:35 UTC+0800 ~ Tao Chen <chen.dylane@linux.dev>
> 在 2025/7/22 23:02, Quentin Monnet 写道:
>> 2025-07-22 20:09 UTC+0800 ~ Tao Chen <chen.dylane@linux.dev>
>>> This commit updates the bash completion script with the new token
>>> argument.
>>> $ bpftool
>>> batch cgroup gen iter map
>>> perf struct_ops
>>> btf feature help link net
>>> prog token
>>
>>
>> This is a terrible example, offering "token" as completion for just
>> "bpftool [tab]" works without this patch :) The main commands are parsed
>> from the output of "bpftool help" so it should work after your first
>> patch. In this one, we add "list", "show" and "help" for completing
>> "bpftool token [tab]".
>>
>
> As you said, how about this one? I will change it in v3, thanks.
> $ bpftool token
> help list show
Yes, perfect
next prev parent reply other threads:[~2025-07-22 16:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 12:09 [RESEND PATCH bpf-next v2 1/3] bpftool: Add bpf_token show Tao Chen
2025-07-22 12:09 ` [PATCH bpf-next v2 2/3] bpftool: Add bpftool-token manpage Tao Chen
2025-07-22 15:01 ` Quentin Monnet
2025-07-22 16:14 ` Tao Chen
2025-07-22 12:09 ` [PATCH bpf-next v2 3/3] bpftool: Add bash completion for token argument Tao Chen
2025-07-22 15:02 ` Quentin Monnet
2025-07-22 16:35 ` Tao Chen
2025-07-22 16:37 ` Quentin Monnet [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-07-22 11:58 [PATCH bpf-next v2 1/3] bpftool: Add bpf_token show Tao Chen
2025-07-22 11:58 ` [PATCH bpf-next v2 3/3] bpftool: Add bash completion for token argument Tao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50872d17-fd8a-4f84-826b-62c08c7d304a@kernel.org \
--to=qmo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chen.dylane@linux.dev \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®