Re: [PATCH bpf-next v2 3/3] bpftool: Add bash completion for token argument

[Quentin Monnet <qmo@kernel.org>]

2025-07-22 20:09 UTC+0800 ~ Tao Chen <chen.dylane@linux.dev>
> This commit updates the bash completion script with the new token
> argument.
> $ bpftool
> batch       cgroup      gen         iter        map         perf        struct_ops
> btf         feature     help        link        net         prog        token


This is a terrible example, offering "token" as completion for just
"bpftool [tab]" works without this patch :) The main commands are parsed
from the output of "bpftool help" so it should work after your first
patch. In this one, we add "list", "show" and "help" for completing
"bpftool token [tab]".


> 
> Signed-off-by: Tao Chen <chen.dylane@linux.dev>
> ---
>  tools/bpf/bpftool/bash-completion/bpftool | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool
> index a759ba24471..527bb47ac46 100644
> --- a/tools/bpf/bpftool/bash-completion/bpftool
> +++ b/tools/bpf/bpftool/bash-completion/bpftool
> @@ -1215,6 +1215,17 @@ _bpftool()
>                      ;;
>              esac
>              ;;
> +        token)
> +            case $command in
> +               show|list)
> +                   return 0
> +                   ;;
> +               *)
> +                   [[ $prev == $object ]] && \
> +                       COMPREPLY=( $( compgen -W 'help show list' -- "$cur" ) )
> +                   ;;
> +            esac
> +            ;;
>      esac
>  } &&
>  complete -F _bpftool bpftool


Other than the example in the description, this looks good.

Reviewed-by: Quentin Monnet <qmo@kernel.org>

Thanks