mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Jijie Shao <shaojijie@huawei.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	shenjian15@huawei.com, salil.mehta@huawei.com
Cc: liuyonglong@huawei.com, wangpeiyang1@huawei.com,
	lanhao@huawei.com, chenhao418@huawei.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 net 1/9] net: hns3: default enable tx bounce buffer when smmu enabled
Date: Thu, 24 Oct 2024 10:26:01 +0200	[thread overview]
Message-ID: <50874428-b4ef-4e65-b60b-1bd917f1933c@redhat.com> (raw)
In-Reply-To: <20241018101059.1718375-2-shaojijie@huawei.com>

On 10/18/24 12:10, Jijie Shao wrote:
> From: Peiyang Wang <wangpeiyang1@huawei.com>
> 
> The SMMU engine on HIP09 chip has a hardware issue.
> SMMU pagetable prefetch features may prefetch and use a invalid PTE
> even the PTE is valid at that time. This will cause the device trigger
> fake pagefaults. The solution is to avoid prefetching by adding a
> SYNC command when smmu mapping a iova. But the performance of nic has a
> sharp drop. Then we do this workaround, always enable tx bounce buffer,
> avoid mapping/unmapping on TX path.
> 
> This issue only affects HNS3, so we always enable
> tx bounce buffer when smmu enabled to improve performance.
> 
> Signed-off-by: Peiyang Wang <wangpeiyang1@huawei.com>
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>

I'm sorry to nick pick on somewhat small details, but we really need a
fixes tag here to make 110% clear is a bugfix. I guess it could be the
commit introducing the support for the buggy H/W.

Thanks,

Paolo


  reply	other threads:[~2024-10-24  8:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 10:10 [PATCH V2 net 0/9] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 1/9] net: hns3: default enable tx bounce buffer when smmu enabled Jijie Shao
2024-10-24  8:26   ` Paolo Abeni [this message]
2024-10-24  8:31     ` Jijie Shao
2024-10-24 16:04       ` Simon Horman
2024-10-25  1:10         ` Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 2/9] net: hns3: add sync command to sync io-pgtable Jijie Shao
2024-10-24  8:36   ` Paolo Abeni
2024-10-24  9:01     ` Jijie Shao
2024-10-24  9:38     ` shenjian (K)
2024-10-24 11:05       ` Paolo Abeni
2024-10-25  1:11         ` Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 3/9] net: hns3: fixed reset failure issues caused by the incorrect reset type Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 4/9] net: hns3: fix missing features due to dev->features configuration too early Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 5/9] net: hns3: Resolved the issue that the debugfs query result is inconsistent Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 6/9] net: hns3: don't auto enable misc vector Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 7/9] net: hns3: initialize reset_timer before hclgevf_misc_irq_init() Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 8/9] net: hns3: fixed hclge_fetch_pf_reg accesses bar space out of bounds issue Jijie Shao
2024-10-18 10:10 ` [PATCH V2 net 9/9] net: hns3: fix kernel crash when 1588 is sent on HIP08 devices Jijie Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50874428-b4ef-4e65-b60b-1bd917f1933c@redhat.com \
    --to=pabeni@redhat.com \
    --cc=chenhao418@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=lanhao@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=shaojijie@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=wangpeiyang1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®