From: Stephen Warren <swarren@wwwdotorg.org>
To: Joe Perches <joe@perches.com>
Cc: Ming Lei <tom.leiming@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Kay Sievers <kay@vrfy.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH 03/23] printk: Move braille console support into separate braille.[ch] files
Date: Thu, 25 Oct 2012 09:32:05 -0600 [thread overview]
Message-ID: <50895B75.2010102@wwwdotorg.org> (raw)
In-Reply-To: <1351125084.7130.16.camel@joe-AO722>
On 10/24/2012 06:31 PM, Joe Perches wrote:
> On Wed, 2012-10-24 at 18:12 -0600, Stephen Warren wrote:
>> On 10/17/2012 12:06 AM, Joe Perches wrote:
>>> Create files with prototypes and static inlines for braille
>>> support. Make braille_console functions return 1 on success.
>>
>> Joe,
>>
>> Between next-20121022 and next-20121023, the serial console (on the ARM
>> SoC Tegra at least) stopped working. The issue bisects down to this
>> commit. I haven't had a chance to investigate why yet, I just finished
>> bisected.
>>
>> earlyprintk over the same UART works. Once the system has booted, a few
>> late kernel messages do appear, and then getty/login over the UART
>> works. So, it's just the printk messages that disappeared.
>>
>> In case it's relevant, my command-line is:
>>
>> console=ttyS0,115200n8 loglevel=8 rootwait rw earlyprintk
>> root=PARTUUID=b2f82cda-2535-4779-b467-094a210fbae7
>>
>> I'll continue to investigate further tomorrow, but just wanted to give
>> you a heads-up in case you could immediately see anything obvious in the
>> code.
>
> Hi Stephen.
>
> Thanks, I appreciate the heads-up. This should be solved
> by Ming Lei's patch (which I've incorporated into a V2
> series I will post shortly).
>
> https://lkml.org/lkml/2012/10/23/307
Thanks. I can confirmed that patch does fix my issue.
next prev parent reply other threads:[~2012-10-25 15:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 6:06 [PATCH 00/23] printk: refactoring Joe Perches
2012-10-17 6:06 ` [PATCH 01/23] printk: Move to separate directory for easier modification Joe Perches
2012-10-17 6:06 ` [PATCH 02/23] printk: Add console_cmdline.h Joe Perches
2012-10-17 6:06 ` [PATCH 03/23] printk: Move braille console support into separate braille.[ch] files Joe Perches
2012-10-17 23:47 ` Samuel Thibault
2012-10-25 0:12 ` Stephen Warren
2012-10-25 0:31 ` Joe Perches
2012-10-25 15:32 ` Stephen Warren [this message]
2012-10-17 6:06 ` [PATCH 04/23] printk: Use pointer for console_cmdline indexing Joe Perches
2012-10-17 6:06 ` [PATCH 05/23] printk: rename struct log to struct printk_log Joe Perches
2012-10-17 6:06 ` [PATCH 06/23] printk: Rename log_buf and __LOG_BUF_LEN Joe Perches
2012-10-17 6:06 ` [PATCH 07/23] printk: Rename log_first and log_next variables Joe Perches
2012-10-17 6:06 ` [PATCH 08/23] printk: Rename log_<foo> variables and functions Joe Perches
2012-10-17 6:06 ` [PATCH 09/23] printk: Rename enum log_flags to printk_log_flags Joe Perches
2012-10-17 6:06 ` [PATCH 10/23] printk: Rename log_wait to printk_log_wait Joe Perches
2012-10-17 6:06 ` [PATCH 11/23] printk: Rename logbuf_lock to printk_logbuf_lock Joe Perches
2012-10-17 6:06 ` [PATCH 12/23] printk: Rename clear_seq and clear_idx variables Joe Perches
2012-10-17 6:06 ` [PATCH 13/23] printk: Remove static from printk_ variables Joe Perches
2012-10-17 6:06 ` [PATCH 14/23] printk: Rename LOG_ALIGN to PRINTK_LOG_ALIGN Joe Perches
2012-10-17 6:06 ` [PATCH 15/23] printk: Add and use printk_log.h Joe Perches
2012-10-17 6:06 ` [PATCH 16/23] printk: Add printk_log.c Joe Perches
2012-10-17 6:06 ` [PATCH 17/23] printk: Make wait_queue_head_t printk_log_wait extern Joe Perches
2012-10-17 6:06 ` [PATCH 18/23] printk: Rename and move 2 #defines to printk_log.h Joe Perches
2012-10-17 6:06 ` [PATCH 19/23] printk: Move devkmsg bits to separate file Joe Perches
2012-10-17 6:06 ` [PATCH 20/23] printk: Prefix print_time and msg_print_text with printk_ Joe Perches
2012-10-17 6:06 ` [PATCH 21/23] printk: Move functions printk_print_time and printk_msg_print_text Joe Perches
2012-10-17 6:06 ` [PATCH 22/23] printk: Add printk_syslog.c and .h Joe Perches
2012-10-17 6:06 ` [PATCH 23/23] printk: Move kmsg_dump functions to separate file Joe Perches
2012-10-18 23:16 ` [PATCH 00/23] printk: refactoring Andrew Morton
2012-10-19 0:43 ` Joe Perches
2012-10-19 1:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50895B75.2010102@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome