* [PATCH RESEND v3.7.0] Add AHCI support for Enmotus Bobcat device.
@ 2013-01-03 18:35 Hugh Daschbach
2013-01-03 19:51 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Hugh Daschbach @ 2013-01-03 18:35 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, linux-kernel, Hugh Daschbach
Silicon does not support standard AHCI BAR assignment. Add
vendor/device exception to force BAR 2.
Signed-off-by: Hugh Daschbach <hugh.daschbach@enmotus.com>
---
Previously sent 14 Dec 2012. Any feedback?
Thanks,
Hugh
drivers/ata/ahci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 7862d17..3cb008f 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -53,6 +53,7 @@
enum {
AHCI_PCI_BAR_STA2X11 = 0,
+ AHCI_PCI_BAR_ENMOTUS = 2,
AHCI_PCI_BAR_STANDARD = 5,
};
@@ -410,6 +411,9 @@ static const struct pci_device_id ahci_pci_tbl[] = {
{ PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci }, /* ASM1061 */
{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci }, /* ASM1062 */
+ /* Enmotus */
+ { PCI_DEVICE(0x1c44, 0x8000), board_ahci },
+
/* Generic, PCI class code for AHCI */
{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci },
@@ -1101,6 +1105,8 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
/* The Connext uses non-standard BAR */
if (pdev->vendor == PCI_VENDOR_ID_STMICRO && pdev->device == 0xCC06)
ahci_pci_bar = AHCI_PCI_BAR_STA2X11;
+ else if (pdev->vendor == 0x1c44 && pdev->device == 0x8000)
+ ahci_pci_bar = AHCI_PCI_BAR_ENMOTUS;
/* acquire resources */
rc = pcim_enable_device(pdev);
--
1.7.11.7
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND v3.7.0] Add AHCI support for Enmotus Bobcat device.
2013-01-03 18:35 [PATCH RESEND v3.7.0] Add AHCI support for Enmotus Bobcat device Hugh Daschbach
@ 2013-01-03 19:51 ` Sergei Shtylyov
2013-01-04 22:39 ` [PATCH v2 " Hugh Daschbach
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2013-01-03 19:51 UTC (permalink / raw)
To: Hugh Daschbach; +Cc: Jeff Garzik, linux-ide, linux-kernel
Hello.
On 01/03/2013 09:35 PM, Hugh Daschbach wrote:
> Silicon does not support standard AHCI BAR assignment. Add
> vendor/device exception to force BAR 2.
> Signed-off-by: Hugh Daschbach <hugh.daschbach@enmotus.com>
> ---
> Previously sent 14 Dec 2012. Any feedback?
> Thanks,
> Hugh
> drivers/ata/ahci.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 7862d17..3cb008f 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
[...]
> @@ -1101,6 +1105,8 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> /* The Connext uses non-standard BAR */
This comment probably needs updating now to include your device.
> if (pdev->vendor == PCI_VENDOR_ID_STMICRO && pdev->device == 0xCC06)
> ahci_pci_bar = AHCI_PCI_BAR_STA2X11;
> + else if (pdev->vendor == 0x1c44 && pdev->device == 0x8000)
> + ahci_pci_bar = AHCI_PCI_BAR_ENMOTUS;
>
> /* acquire resources */
> rc = pcim_enable_device(pdev);
>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 v3.7.0] Add AHCI support for Enmotus Bobcat device.
2013-01-03 19:51 ` Sergei Shtylyov
@ 2013-01-04 22:39 ` Hugh Daschbach
0 siblings, 0 replies; 3+ messages in thread
From: Hugh Daschbach @ 2013-01-04 22:39 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Jeff Garzik, linux-ide, linux-kernel, Hugh Daschbach
Silicon does not support standard AHCI BAR assignment. Add
vendor/device exception to force BAR 2.
Signed-off-by: Hugh Daschbach <hugh.daschbach@enmotus.com>
---
v2: Corrected comment in response to Sergei's review. Thanks, Sergei.
drivers/ata/ahci.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 7862d17..4979127 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -53,6 +53,7 @@
enum {
AHCI_PCI_BAR_STA2X11 = 0,
+ AHCI_PCI_BAR_ENMOTUS = 2,
AHCI_PCI_BAR_STANDARD = 5,
};
@@ -410,6 +411,9 @@ static const struct pci_device_id ahci_pci_tbl[] = {
{ PCI_VDEVICE(ASMEDIA, 0x0611), board_ahci }, /* ASM1061 */
{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci }, /* ASM1062 */
+ /* Enmotus */
+ { PCI_DEVICE(0x1c44, 0x8000), board_ahci },
+
/* Generic, PCI class code for AHCI */
{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci },
@@ -1098,9 +1102,11 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
dev_info(&pdev->dev,
"PDC42819 can only drive SATA devices with this driver\n");
- /* The Connext uses non-standard BAR */
+ /* Both Connext and Enmotus devices use non-standard BARs */
if (pdev->vendor == PCI_VENDOR_ID_STMICRO && pdev->device == 0xCC06)
ahci_pci_bar = AHCI_PCI_BAR_STA2X11;
+ else if (pdev->vendor == 0x1c44 && pdev->device == 0x8000)
+ ahci_pci_bar = AHCI_PCI_BAR_ENMOTUS;
/* acquire resources */
rc = pcim_enable_device(pdev);
--
1.7.11.7
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-04 22:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-03 18:35 [PATCH RESEND v3.7.0] Add AHCI support for Enmotus Bobcat device Hugh Daschbach
2013-01-03 19:51 ` Sergei Shtylyov
2013-01-04 22:39 ` [PATCH v2 " Hugh Daschbach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome