From: Ilkka Koskinen <ilkka@os.amperecomputing.com>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] perf/dwc_pcie: Load DesignWare PCIe PMU driver automatically on Ampere SoCs
Date: Wed, 9 Oct 2024 13:07:33 -0700 (PDT) [thread overview]
Message-ID: <50ad8d7c-6ce1-28d-987d-fa4e285f629c@os.amperecomputing.com> (raw)
In-Reply-To: <41a0090c-5c2f-42d3-b8a2-92ec094fab96@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]
Hi Shuai,
On Wed, 9 Oct 2024, Shuai Xue wrote:
> 在 2024/10/9 07:18, Ilkka Koskinen 写道:
>> Load DesignWare PCIe PMU driver automatically if the system has a PCI
>> bridge by Ampere.
>>
>> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
>> ---
>> drivers/perf/dwc_pcie_pmu.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c
>> index 3581d916d851..d752168733cf 100644
>> --- a/drivers/perf/dwc_pcie_pmu.c
>> +++ b/drivers/perf/dwc_pcie_pmu.c
>> @@ -782,6 +782,16 @@ static void __exit dwc_pcie_pmu_exit(void)
>> module_init(dwc_pcie_pmu_init);
>> module_exit(dwc_pcie_pmu_exit);
>> +static const struct pci_device_id dwc_pcie_pmu_table[] = {
>> + {
>> + PCI_DEVICE(PCI_VENDOR_ID_AMPERE, PCI_ANY_ID),
>
> Hi, Ilkka,
>
> Does all Ampere PCI bridge use this IP?
I have checked Altra, AltraMax and AmpereOne SoCs and they all do.
Unfortunately, I don't have access to eMAG at this point. If the IP
will be changed and the feature won't be supported in the future SoCs,
I can certainly change the logic to accept only certain SoCs.
Cheers, Ilkka
>
> Best Regards,
> Shuai
>
>
>
next prev parent reply other threads:[~2024-10-09 20:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 23:18 [PATCH 0/3] perf/dwc_pcie: Enable DesignWare PCIe PMU " Ilkka Koskinen
2024-10-08 23:18 ` [PATCH 1/3] perf/dwc_pcie: Add support for " Ilkka Koskinen
2024-10-09 1:30 ` Shuai Xue
2024-10-08 23:18 ` [PATCH 2/3] perf/dwc_pcie: Load DesignWare PCIe PMU driver automatically on " Ilkka Koskinen
2024-10-09 1:42 ` Shuai Xue
2024-10-09 20:07 ` Ilkka Koskinen [this message]
2024-10-09 21:53 ` kernel test robot
2024-10-09 22:14 ` kernel test robot
2024-10-24 11:32 ` Will Deacon
2024-10-24 22:19 ` Ilkka Koskinen
2024-10-28 17:31 ` Will Deacon
2024-10-29 3:27 ` Ilkka Koskinen
2024-10-29 13:00 ` Will Deacon
2024-10-29 15:39 ` Jonathan Cameron
2024-10-08 23:18 ` [PATCH 3/3] perf/dwc_pcie: Fix typos in event names Ilkka Koskinen
2024-10-09 1:44 ` Shuai Xue
2024-10-09 9:07 ` Jing Zhang
2024-10-29 16:15 ` [PATCH 0/3] perf/dwc_pcie: Enable DesignWare PCIe PMU on Ampere SoCs Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ad8d7c-6ce1-28d-987d-fa4e285f629c@os.amperecomputing.com \
--to=ilkka@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®