* [PATCH] drm/amd/amdgpu: fix potential memleak
@ 2021-11-15 2:58 Bernard Zhao
2021-11-15 15:56 ` Felix Kuehling
0 siblings, 1 reply; 3+ messages in thread
From: Bernard Zhao @ 2021-11-15 2:58 UTC (permalink / raw)
To: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter, Hawking Zhang, John Clements, Jonathan Kim,
Felix Kuehling, Kevin Wang, Tian Tao, Evan Quan, shaoyunl,
amd-gfx, dri-devel, linux-kernel
Cc: Bernard Zhao
In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed
There is a potential memleak if not call kobject_put.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 0fad2bf854ae..567df2db23ac 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
@@ -386,6 +386,7 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
"%s", "xgmi_hive_info");
if (ret) {
dev_err(adev->dev, "XGMI: failed initializing kobject for xgmi hive\n");
+ kobject_put(&hive->kobj);
kfree(hive);
hive = NULL;
goto pro_end;
--
2.33.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/amdgpu: fix potential memleak
2021-11-15 2:58 [PATCH] drm/amd/amdgpu: fix potential memleak Bernard Zhao
@ 2021-11-15 15:56 ` Felix Kuehling
2021-11-17 21:34 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Felix Kuehling @ 2021-11-15 15:56 UTC (permalink / raw)
To: Bernard Zhao, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Hawking Zhang, John Clements,
Jonathan Kim, Kevin Wang, Tian Tao, Evan Quan, shaoyunl, amd-gfx,
dri-devel, linux-kernel
Am 2021-11-14 um 9:58 p.m. schrieb Bernard Zhao:
> In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed
> There is a potential memleak if not call kobject_put.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index 0fad2bf854ae..567df2db23ac 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -386,6 +386,7 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
> "%s", "xgmi_hive_info");
> if (ret) {
> dev_err(adev->dev, "XGMI: failed initializing kobject for xgmi hive\n");
> + kobject_put(&hive->kobj);
> kfree(hive);
> hive = NULL;
> goto pro_end;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/amdgpu: fix potential memleak
2021-11-15 15:56 ` Felix Kuehling
@ 2021-11-17 21:34 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-11-17 21:34 UTC (permalink / raw)
To: Felix Kuehling
Cc: Bernard Zhao, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Hawking Zhang, John Clements,
Jonathan Kim, Kevin Wang, Tian Tao, Evan Quan, shaoyunl,
amd-gfx list, Maling list - DRI developers, LKML
Applied. Thanks!
Alex
On Mon, Nov 15, 2021 at 10:56 AM Felix Kuehling <felix.kuehling@amd.com> wrote:
>
> Am 2021-11-14 um 9:58 p.m. schrieb Bernard Zhao:
> > In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed
> > There is a potential memleak if not call kobject_put.
> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> > index 0fad2bf854ae..567df2db23ac 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> > @@ -386,6 +386,7 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
> > "%s", "xgmi_hive_info");
> > if (ret) {
> > dev_err(adev->dev, "XGMI: failed initializing kobject for xgmi hive\n");
> > + kobject_put(&hive->kobj);
> > kfree(hive);
> > hive = NULL;
> > goto pro_end;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-17 21:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 2:58 [PATCH] drm/amd/amdgpu: fix potential memleak Bernard Zhao
2021-11-15 15:56 ` Felix Kuehling
2021-11-17 21:34 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®