* [PATCH] x86/boot: clean up whitespace in a20.c
@ 2025-08-25 17:46 Harry Fellowes
2025-08-25 18:01 ` Xin Li
0 siblings, 1 reply; 2+ messages in thread
From: Harry Fellowes @ 2025-08-25 17:46 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, tglx, mingo, bp, dave.hansen, hpa, Harry Fellowes
Remove trailing whitespace and fix blank lines in arch/x86/boot/a20.c
reported by checkpatch.pl.
No functional changes.
Signed-off-by: Harry Fellowes <harryfellowes1@gmail.com>
---
arch/x86/boot/a20.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
index a2b6b428922a..15bbd4ac55cc 100644
--- a/arch/x86/boot/a20.c
+++ b/arch/x86/boot/a20.c
@@ -135,29 +135,29 @@ int enable_a20(void)
(legacy free, etc.) */
if (a20_test_short())
return 0;
-
+
/* Next, try the BIOS (INT 0x15, AX=0x2401) */
enable_a20_bios();
if (a20_test_short())
return 0;
-
- /* Try enabling A20 through the keyboard controller */
+
+/* Try enabling A20 through the keyboard controller */
kbc_err = empty_8042();
if (a20_test_short())
return 0; /* BIOS worked, but with delayed reaction */
-
- if (!kbc_err) {
+
+if (!kbc_err) {
enable_a20_kbc();
if (a20_test_long())
return 0;
}
-
- /* Finally, try enabling the "fast A20 gate" */
+
+/* Finally, try enabling the "fast A20 gate" */
enable_a20_fast();
if (a20_test_long())
return 0;
}
-
- return -1;
+
+return -1;
}
--
2.51.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/boot: clean up whitespace in a20.c
2025-08-25 17:46 [PATCH] x86/boot: clean up whitespace in a20.c Harry Fellowes
@ 2025-08-25 18:01 ` Xin Li
0 siblings, 0 replies; 2+ messages in thread
From: Xin Li @ 2025-08-25 18:01 UTC (permalink / raw)
To: Harry Fellowes, x86; +Cc: linux-kernel, tglx, mingo, bp, dave.hansen, hpa
On 8/25/2025 10:46 AM, Harry Fellowes wrote:
> Remove trailing whitespace and fix blank lines in arch/x86/boot/a20.c
> reported by checkpatch.pl.
>
> No functional changes.
>
> Signed-off-by: Harry Fellowes <harryfellowes1@gmail.com>
> ---
> arch/x86/boot/a20.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
> index a2b6b428922a..15bbd4ac55cc 100644
> --- a/arch/x86/boot/a20.c
> +++ b/arch/x86/boot/a20.c
> @@ -135,29 +135,29 @@ int enable_a20(void)
> (legacy free, etc.) */
> if (a20_test_short())
> return 0;
> -
> +
This is good.
> /* Next, try the BIOS (INT 0x15, AX=0x2401) */
> enable_a20_bios();
> if (a20_test_short())
> return 0;
> -
> - /* Try enabling A20 through the keyboard controller */
> +
> +/* Try enabling A20 through the keyboard controller */
Why? We do tabs at the beginning.
> kbc_err = empty_8042();
>
> if (a20_test_short())
> return 0; /* BIOS worked, but with delayed reaction */
> -
> - if (!kbc_err) {
> +
> +if (!kbc_err) {
...
> enable_a20_kbc();
> if (a20_test_long())
> return 0;
> }
> -
> - /* Finally, try enabling the "fast A20 gate" */
> +
> +/* Finally, try enabling the "fast A20 gate" */
...
> enable_a20_fast();
> if (a20_test_long())
> return 0;
> }
> -
> - return -1;
> +
> +return -1;
Fix one but then add four, not a good deal.
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-25 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-25 17:46 [PATCH] x86/boot: clean up whitespace in a20.c Harry Fellowes
2025-08-25 18:01 ` Xin Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®