* Fwd: [PATCH] drivers/regulator/twl-*: bettet set NUL after free
[not found] <510F226E.4070401@asianux.com>
@ 2013-02-04 2:55 ` Chen Gang
0 siblings, 0 replies; only message in thread
From: Chen Gang @ 2013-02-04 2:55 UTC (permalink / raw)
To: linux-kernel, lrg, broonie, Peter Ujfalusi, Tony Lindgren
oh, sorry, not sent to mailing-list, originally.
(this patch should send to public kernel mailing list)
-------- 原始消息 --------
主题: [PATCH] drivers/regulator/twl-*: bettet set NUL after free
日期: Mon, 04 Feb 2013 10:52:30 +0800
发件人: Chen Gang <gang.chen@asianux.com>
收件人: lrg@ti.com, broonie@opensource.wolfsonmicro.com, Peter Ujfalusi <peter.ujfalusi@ti.com>, Tony Lindgren <tony@atomide.com>
in .remove function, better to set NUL after free, just like others.
in drivers/power/twl4030_charger.c, has already set NULL after free.
in drivers/input/keyboard/twl4030_keypad.c, has already set NUL after free.
additional info:
maybe this is not a bug, only for beautify code (can treat it as minor patch)
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/regulator/twl-regulator.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 74508cc..a9ab46a 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -1247,6 +1247,7 @@ static int twlreg_remove(struct platform_device *pdev)
struct twlreg_info *info = rdev->reg_data;
regulator_unregister(rdev);
+ platform_set_drvdata(pdev, NULL);
kfree(info);
return 0;
}
--
1.7.7.6
^ permalink raw reply [flat|nested] only message in thread