From: stuart h <stuart_hayes@yahoo.com>
To: linux-kernel@vger.kernel.org, douglas_warzecha@dell.com
Cc: shyam_iyer@dell.com
Subject: [PATCH v2] dcdbas: force SMI to happen when expected
Date: Thu, 24 Feb 2011 18:35:05 -0800 (PST) [thread overview]
Message-ID: <518456.82543.qm@web38004.mail.mud.yahoo.com> (raw)
This is a reworked version of a very similar patch I sent about three weeks ago... a flaw was pointed out with the original. That patch didn't make it into the kernel, though, so I'm just sending this one as a new patch.
The dcdbas driver can do an I/O write to cause a SMI to occur. The SMI handler looks at certain registers and memory locations, so the SMI needs to happen immediately. On some systems I/O writes are posted, though, causing the SMI to happen well after the "outb" occurred, which causes random failures. Following the "outb" with an "inb" forces the write to go through even if it is posted.
This patch is against the 2.6.37.1 kernel.
Signed-off-by: Stuart Hayes <stuart_hayes@yahoo.com>
---
--- linux-2.6.37/drivers/firmware/dcdbas.c 2011-01-18 10:44:44.869882461 -0500
+++ linux-2.6.37_test/drivers/firmware/dcdbas.c 2011-02-24 13:23:58.663771596 -0500
@@ -268,8 +268,10 @@ int dcdbas_smi_request(struct smi_cmd *s
}
/* generate SMI */
+ /* inb to force posted write through and make SMI happen now */
asm volatile (
- "outb %b0,%w1"
+ "outb %b0,%w1\n"
+ "inb %w1"
: /* no output args */
: "a" (smi_cmd->command_code),
"d" (smi_cmd->command_address),
next reply other threads:[~2011-02-25 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 2:35 stuart h [this message]
2011-03-01 14:57 ` Jiri Kosina
2011-03-01 15:53 ` Douglas_Warzecha
2011-03-02 12:42 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518456.82543.qm@web38004.mail.mud.yahoo.com \
--to=stuart_hayes@yahoo.com \
--cc=douglas_warzecha@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®