* [PATCH v2] dcdbas: force SMI to happen when expected
@ 2011-02-25 2:35 stuart h
2011-03-01 14:57 ` Jiri Kosina
2011-03-01 15:53 ` Douglas_Warzecha
0 siblings, 2 replies; 4+ messages in thread
From: stuart h @ 2011-02-25 2:35 UTC (permalink / raw)
To: linux-kernel, douglas_warzecha; +Cc: shyam_iyer
This is a reworked version of a very similar patch I sent about three weeks ago... a flaw was pointed out with the original. That patch didn't make it into the kernel, though, so I'm just sending this one as a new patch.
The dcdbas driver can do an I/O write to cause a SMI to occur. The SMI handler looks at certain registers and memory locations, so the SMI needs to happen immediately. On some systems I/O writes are posted, though, causing the SMI to happen well after the "outb" occurred, which causes random failures. Following the "outb" with an "inb" forces the write to go through even if it is posted.
This patch is against the 2.6.37.1 kernel.
Signed-off-by: Stuart Hayes <stuart_hayes@yahoo.com>
---
--- linux-2.6.37/drivers/firmware/dcdbas.c 2011-01-18 10:44:44.869882461 -0500
+++ linux-2.6.37_test/drivers/firmware/dcdbas.c 2011-02-24 13:23:58.663771596 -0500
@@ -268,8 +268,10 @@ int dcdbas_smi_request(struct smi_cmd *s
}
/* generate SMI */
+ /* inb to force posted write through and make SMI happen now */
asm volatile (
- "outb %b0,%w1"
+ "outb %b0,%w1\n"
+ "inb %w1"
: /* no output args */
: "a" (smi_cmd->command_code),
"d" (smi_cmd->command_address),
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] dcdbas: force SMI to happen when expected
2011-02-25 2:35 [PATCH v2] dcdbas: force SMI to happen when expected stuart h
@ 2011-03-01 14:57 ` Jiri Kosina
2011-03-01 15:53 ` Douglas_Warzecha
1 sibling, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2011-03-01 14:57 UTC (permalink / raw)
To: stuart h; +Cc: linux-kernel, douglas_warzecha, shyam_iyer
On Thu, 24 Feb 2011, stuart h wrote:
> This is a reworked version of a very similar patch I sent about three
> weeks ago... a flaw was pointed out with the original. That patch
> didn't make it into the kernel, though, so I'm just sending this one as
> a new patch.
>
> The dcdbas driver can do an I/O write to cause a SMI to occur. The SMI
> handler looks at certain registers and memory locations, so the SMI
> needs to happen immediately. On some systems I/O writes are posted,
> though, causing the SMI to happen well after the "outb" occurred, which
> causes random failures. Following the "outb" with an "inb" forces the
> write to go through even if it is posted.
>
> This patch is against the 2.6.37.1 kernel.
>
> Signed-off-by: Stuart Hayes <stuart_hayes@yahoo.com>
As this doesn't seem to be picked up ... Douglas, can I have your
Acked-by: please, so that I could merge it (as Acked by maintainer?).
Thanks.
> --- linux-2.6.37/drivers/firmware/dcdbas.c 2011-01-18 10:44:44.869882461 -0500
> +++ linux-2.6.37_test/drivers/firmware/dcdbas.c 2011-02-24 13:23:58.663771596 -0500
> @@ -268,8 +268,10 @@ int dcdbas_smi_request(struct smi_cmd *s
> }
>
> /* generate SMI */
> + /* inb to force posted write through and make SMI happen now */
> asm volatile (
> - "outb %b0,%w1"
> + "outb %b0,%w1\n"
> + "inb %w1"
> : /* no output args */
> : "a" (smi_cmd->command_code),
> "d" (smi_cmd->command_address),
>
>
>
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dcdbas: force SMI to happen when expected
2011-02-25 2:35 [PATCH v2] dcdbas: force SMI to happen when expected stuart h
2011-03-01 14:57 ` Jiri Kosina
@ 2011-03-01 15:53 ` Douglas_Warzecha
2011-03-02 12:42 ` Jiri Kosina
1 sibling, 1 reply; 4+ messages in thread
From: Douglas_Warzecha @ 2011-03-01 15:53 UTC (permalink / raw)
To: stuart_hayes, linux-kernel; +Cc: Shyam_Iyer
On 02/24/2011 8:35 PM, Stuart Hayes wrote:
> This is a reworked version of a very similar patch I sent about three
> weeks ago... a flaw was pointed out with the original. That patch
> didn't make it into the kernel, though, so I'm just sending this one as
> a new patch.
>
> The dcdbas driver can do an I/O write to cause a SMI to occur. The SMI
> handler looks at certain registers and memory locations, so the SMI
> needs to happen immediately. On some systems I/O writes are posted,
> though, causing the SMI to happen well after the "outb" occurred, which
> causes random failures. Following the "outb" with an "inb" forces the
> write to go through even if it is posted.
>
> This patch is against the 2.6.37.1 kernel.
>
> Signed-off-by: Stuart Hayes <stuart_hayes@yahoo.com>
> ---
>
> --- linux-2.6.37/drivers/firmware/dcdbas.c 2011-01-18
> 10:44:44.869882461 -0500
> +++ linux-2.6.37_test/drivers/firmware/dcdbas.c 2011-02-24
> 13:23:58.663771596 -0500
> @@ -268,8 +268,10 @@ int dcdbas_smi_request(struct smi_cmd *s
> }
>
> /* generate SMI */
> + /* inb to force posted write through and make SMI happen now */
> asm volatile (
> - "outb %b0,%w1"
> + "outb %b0,%w1\n"
> + "inb %w1"
> : /* no output args */
> : "a" (smi_cmd->command_code),
> "d" (smi_cmd->command_address),
>
Acked-by: Doug Warzecha <douglas_warzecha@dell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dcdbas: force SMI to happen when expected
2011-03-01 15:53 ` Douglas_Warzecha
@ 2011-03-02 12:42 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2011-03-02 12:42 UTC (permalink / raw)
To: Douglas_Warzecha; +Cc: stuart_hayes, linux-kernel, Shyam_Iyer
On Tue, 1 Mar 2011, Douglas_Warzecha@Dell.com wrote:
> > This is a reworked version of a very similar patch I sent about three
> > weeks ago... a flaw was pointed out with the original. That patch
> > didn't make it into the kernel, though, so I'm just sending this one as
> > a new patch.
> >
> > The dcdbas driver can do an I/O write to cause a SMI to occur. The SMI
> > handler looks at certain registers and memory locations, so the SMI
> > needs to happen immediately. On some systems I/O writes are posted,
> > though, causing the SMI to happen well after the "outb" occurred, which
> > causes random failures. Following the "outb" with an "inb" forces the
> > write to go through even if it is posted.
> >
> > This patch is against the 2.6.37.1 kernel.
> >
> > Signed-off-by: Stuart Hayes <stuart_hayes@yahoo.com>
> > ---
> >
> > --- linux-2.6.37/drivers/firmware/dcdbas.c 2011-01-18
> > 10:44:44.869882461 -0500
> > +++ linux-2.6.37_test/drivers/firmware/dcdbas.c 2011-02-24
> > 13:23:58.663771596 -0500
> > @@ -268,8 +268,10 @@ int dcdbas_smi_request(struct smi_cmd *s
> > }
> >
> > /* generate SMI */
> > + /* inb to force posted write through and make SMI happen now */
> > asm volatile (
> > - "outb %b0,%w1"
> > + "outb %b0,%w1\n"
> > + "inb %w1"
> > : /* no output args */
> > : "a" (smi_cmd->command_code),
> > "d" (smi_cmd->command_address),
> >
>
> Acked-by: Doug Warzecha <douglas_warzecha@dell.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-02 12:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-25 2:35 [PATCH v2] dcdbas: force SMI to happen when expected stuart h
2011-03-01 14:57 ` Jiri Kosina
2011-03-01 15:53 ` Douglas_Warzecha
2011-03-02 12:42 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®