mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Armin Wolf <W_Armin@gmx.de>, GG <ggirouard@bungeetaco.com>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] hwmon: (spd5118) resume fails -ENXIO on write protected hubs
Date: Mon, 17 Aug 2026 22:44:48 -0700	[thread overview]
Message-ID: <519971fa-4ae2-47b2-93f4-fe85cca05e62@roeck-us.net> (raw)
In-Reply-To: <005e108a-a337-4c50-bc2e-aa7d933b7e2a@gmx.de>

On 8/17/26 22:00, Armin Wolf wrote:
...
>>>
>>> Looking into the code, it seems like the device may have been instantiated
>>> through the detect path. That makes me wonder which distribution enables
>>> CONFIG_SENSORS_SPD5118_DETECT because it should _not_ be enabled by default.
>>>
>>> Anyway, I guess I'll have to implement a dummy write operation in
>>> spd5118_i2c_init() to check if writes are possible and bail out on error.
>>> That is less than perfect but the best we can do without a flag from the
>>> I2C controller.
>>>
>>> I'll look into that after the commit window closes.
>>>
>>> Thanks,
>>> Guenter
>>
>> I already have prepared two patches for that, i will test them on my machine as soon as possible.
>>
>> Thanks,
>> Armin Wolf 
> 
> Both patches seems to work, but i do not have an DDR5-based Intel system and hand. Still, do you want
> me to send those patches when the new merge window opens?
> 

Please do. We should see a couple of patches applied to the spd5118 driver
during the commit window, adding I3C support, so please remember to rebase
your patches on top of v7.3-rc1 before you send them.

Thanks,
Guenter


  reply	other threads:[~2026-08-18  5:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 16:29 GG
2026-08-17 16:42 ` GG
2026-08-17 16:58   ` Guenter Roeck
2026-08-17 17:03     ` GG
2026-08-17 23:02       ` Armin Wolf
2026-08-18  0:11         ` Guenter Roeck
2026-08-18  3:50           ` Armin Wolf
2026-08-18  5:00             ` Armin Wolf
2026-08-18  5:44               ` Guenter Roeck [this message]
2026-08-17 16:53 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519971fa-4ae2-47b2-93f4-fe85cca05e62@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=W_Armin@gmx.de \
    --cc=ggirouard@bungeetaco.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®