mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: GG <ggirouard@bungeetaco.com>, Guenter Roeck <linux@roeck-us.net>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] hwmon: (spd5118) resume fails -ENXIO on write protected hubs
Date: Tue, 18 Aug 2026 01:02:33 +0200	[thread overview]
Message-ID: <ebcb1afb-26db-46f6-8e9d-30218190870b@gmx.de> (raw)
In-Reply-To: <jjJPzuDEBRVJ3kZwlt43bdlePFCpQRMREjsEVngkNZLaCQDi9wBEEZb4U-2nvZ67qskaP8WSEbux8AmWenQGHT0WIvFQ6ZU2G4zQl3Lb4Vw=@bungeetaco.com>

Am 17.08.26 um 19:03 schrieb GG:

> Understood - thanks for explaining the page selection part, that makes sense. I'll blacklist it for now.
>
> Appreciate you taking the time to get back to me on this!
>
> Gabriel G
>
> On Monday, August 17th, 2026 at 12:58 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>
>> On 8/17/26 09:42, GG wrote:
>>> Sorry - I should have searched the archives before sending my last email. I've since
>>> found this from February, which is the same problem:
>>>
>>>     https://lore.kernel.org/linux-hwmon/20260205102942.28745-1-tinsaetadesse2015@gmail.com/
>>>
>>> And I missed the obvious clue sitting in my own boot log:
>>>
>>>     i801_smbus 0000:00:1f.4: SPD Write Disable is set
>>>
>>> So my kernel already knew. Apologies for the noise.
>>>
>> Unfortunately that knowledge is not passed on to the spd5118 driver.

Yes, sadly the patch series adding support for this was abandoned :/

>>> One thing I'll mention in case it's useful: that series above has spd5118 refuse to
>>> probe when writes are disabled. On my machine that would lose me two working
>>> temperature sensors. Reads are completely fine here, I get correct temps,
>>> and my temperature limits read back properly. It's only writing that fails.
>>>
>>> Happy to test anything on my hardware if it would help.
>>>
>> That can not be done, as I mentioned in my other e-mail.
>>
>> Problem is that accessing temperature sensor data on spd5118 compatible chips
>> requires a write to select the correct chip page. If writes are disabled, and
>> the BIOS selected a page other than page 0, temperature sensor data is not
>> accessible. Since the BIOS can do whatever it wants and may have selected a
>> different page after a suspend/resume sequence, one simply can not trust
>> the status when the driver is loaded initially.
>>
>> Guenter

Would it be enough if we always select page 0 inside spd5118_i2c_init(), thereby
preventing the driver from probing on hardware that does not allow us to write
the page select register?

Thanks,
Armin Wolf


  reply	other threads:[~2026-08-17 23:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 16:29 GG
2026-08-17 16:42 ` GG
2026-08-17 16:58   ` Guenter Roeck
2026-08-17 17:03     ` GG
2026-08-17 23:02       ` Armin Wolf [this message]
2026-08-18  0:11         ` Guenter Roeck
2026-08-18  3:50           ` Armin Wolf
2026-08-18  5:00             ` Armin Wolf
2026-08-18  5:44               ` Guenter Roeck
2026-08-17 16:53 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebcb1afb-26db-46f6-8e9d-30218190870b@gmx.de \
    --to=w_armin@gmx.de \
    --cc=ggirouard@bungeetaco.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®