Re: [PATCH 1/3] watchdog: xilinx: Fix driver header

[Alejandro Cabrera <acabrera@udio.cujae.edu.cu>]

On 30/5/2013 7:32 AM, Michal Simek wrote:
> On 05/30/2013 02:30 PM, Venu Byravarasu wrote:
>>> -----Original Message-----
>>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
>>> owner@vger.kernel.org] On Behalf Of Michal Simek
>>> Sent: Thursday, May 30, 2013 5:56 PM
>>> To: linux-kernel@vger.kernel.org
>>> Cc: Michal Simek; Michal Simek; Wim Van Sebroeck; linux-
>>> watchdog@vger.kernel.org
>>> Subject: [PATCH 1/3] watchdog: xilinx: Fix driver header
>>>
>>> * PGP Signed by an unknown key
>>>
>>> - Remove reference for IP version
>>> - Fix header coding style
>>> - Remove notes which are visible from the code
>>> - Fix driver license according to header
>>>
>>> Signed-off-by: Michal Simek<michal.simek@xilinx.com>
>>> ---
>>>   drivers/watchdog/of_xilinx_wdt.c | 30 ++++++++++--------------------
>>>   1 file changed, 10 insertions(+), 20 deletions(-)
>>>
>>> diff --git a/drivers/watchdog/of_xilinx_wdt.c
>>> b/drivers/watchdog/of_xilinx_wdt.c
>>> index 2761ddb..d4a35ab 100644
>>> --- a/drivers/watchdog/of_xilinx_wdt.c
>>> +++ b/drivers/watchdog/of_xilinx_wdt.c
>>> @@ -1,23 +1,13 @@
>>>   /*
>>> -*   of_xilinx_wdt.c  1.01  A Watchdog Device Driver for Xilinx
>>> xps_timebase_wdt
>>> -*
>>> -*   (C) Copyright 2011 (Alejandro Cabrera<aldaya@gmail.com>)
>>> -*
>>> -*       -----------------------
>>> -*/
>>> + * Watchdog Device Driver for Xilinx axi/xps_timebase_wdt
>>> + *
>>> + * (C) Copyright 2011 (Alejandro Cabrera<aldaya@gmail.com>)
>> Should year not be updated?
> This is just header fixup.
> I think he is not working/maintaining this driver for a long time.
Indeed :(.
Since this driver was upstream the new watchdog subsystem was under 
development and I want to port it to the new core, but unfortunately I 
haven't enough time :(.
> I would write there Xilinx copyright but I really don't care.
>
> Thanks,
> Michal
Thanks, you,
Alejandro




48 Aniversario de la Cujae, Una obra de la Revolucion Cubana | 2 de diciembre de 1964 | http://cujae.edu.cu

Consulte la enciclopedia colaborativa cubana. http://www.ecured.cu