mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhao mengmeng <zhaomzhao@126.com>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>
Cc: tj@kernel.org, void@manifault.com, arighi@nvidia.com,
	changwoo@igalia.com, sched-ext@lists.linux.dev,
	linux-kernel@vger.kernel.org, zhaomengmeng@kylinos.cn,
	jserv@ccns.ncku.edu.tw, chia7712@gmail.com
Subject: Re: [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help
Date: Wed, 15 Apr 2026 18:48:48 +0800	[thread overview]
Message-ID: <51DAF579-BDFD-40C3-9518-F0FD21E1C669@126.com> (raw)
In-Reply-To: <yyq2xc5xpdop65bvs3t7ncmqvw3ilpby75ywzv7g4gmq33hsxy@pohcz6wovyct>

On April 15, 2026 6:46:22 PM GMT+08:00, Cheng-Yang Chou <yphbchou0911@gmail.com> wrote:
>Hi Zhao,
>
>On Wed, Apr 15, 2026 at 05:54:17PM +0800, Zhao Mengmeng wrote:
>> diff --git a/tools/sched_ext/scx_qmap.c b/tools/sched_ext/scx_qmap.c
>> index e7c89a2bc3d8..b5fce6dcee14 100644
>> --- a/tools/sched_ext/scx_qmap.c
>> +++ b/tools/sched_ext/scx_qmap.c
>> @@ -32,6 +32,7 @@ const char help_fmt[] =
>>  "  -P            Print out DSQ content and event counters to trace_pipe every second\n"
>>  "  -M            Print out debug messages to trace_pipe\n"
>>  "  -H            Boost nice -20 tasks in SHARED_DSQ, use with -b\n"
>> +"  -c CG_PATH    Cgroup path to attach as sub-scheduler, must run parent scheduler first\n"
>>  "  -d PID        Disallow a process from switching into SCHED_EXT (-1 for self)\n"
>>  "  -D LEN        Set scx_exit_info.dump buffer length\n"
>>  "  -S            Suppress qmap-specific debug dump\n"
>
>Could you also add [-c CG_PATH] to the usage synopsis in help_fmt?
>Thanks!
>
>Reviewed-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
>

OK, will do it.


  reply	other threads:[~2026-04-15 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15  9:54 [PATCH 0/2] sched_ext: Cgroup sub-scheduler minor fixes Zhao Mengmeng
2026-04-15  9:54 ` [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help Zhao Mengmeng
2026-04-15 10:46   ` Cheng-Yang Chou
2026-04-15 10:48     ` Zhao mengmeng [this message]
2026-04-15  9:54 ` [PATCH 2/2] sched_ext: Print sub-scheduler disabled log and reason Zhao Mengmeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DAF579-BDFD-40C3-9518-F0FD21E1C669@126.com \
    --to=zhaomzhao@126.com \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=chia7712@gmail.com \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    --cc=yphbchou0911@gmail.com \
    --cc=zhaomengmeng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®