* [PATCH 0/2] sched_ext: Cgroup sub-scheduler minor fixes @ 2026-04-15 9:54 Zhao Mengmeng 2026-04-15 9:54 ` [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help Zhao Mengmeng 2026-04-15 9:54 ` [PATCH 2/2] sched_ext: Print sub-scheduler disabled log and reason Zhao Mengmeng 0 siblings, 2 replies; 5+ messages in thread From: Zhao Mengmeng @ 2026-04-15 9:54 UTC (permalink / raw) To: tj, void, arighi, changwoo; +Cc: sched-ext, linux-kernel, zhaomengmeng From: Zhao Mengmeng <zhaomengmeng@kylinos.cn> This patchset contains two fixes that I met when testing cgroup sub-scheduler. Patch 1 add the -c option to scx_qmap help, which support sub-scheduler but has no clue how to use it. Patch 2 add logs when sub- scheduler is disabled, almost the same logic as root scheduler. Zhao Mengmeng (2): tools/sched_ext: Add missing -c option in scx_qmap help sched_ext: Print sub-scheduler disabled log and reason kernel/sched/ext.c | 39 +++++++++++++++++++++++--------------- tools/sched_ext/scx_qmap.c | 1 + 2 files changed, 25 insertions(+), 15 deletions(-) -- 2.43.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help 2026-04-15 9:54 [PATCH 0/2] sched_ext: Cgroup sub-scheduler minor fixes Zhao Mengmeng @ 2026-04-15 9:54 ` Zhao Mengmeng 2026-04-15 10:46 ` Cheng-Yang Chou 2026-04-15 9:54 ` [PATCH 2/2] sched_ext: Print sub-scheduler disabled log and reason Zhao Mengmeng 1 sibling, 1 reply; 5+ messages in thread From: Zhao Mengmeng @ 2026-04-15 9:54 UTC (permalink / raw) To: tj, void, arighi, changwoo; +Cc: sched-ext, linux-kernel, zhaomengmeng From: Zhao Mengmeng <zhaomengmeng@kylinos.cn> The sub-scheduler api has been added to scx_qmap, but the new -c option is missing in help, which is hard to understand and use. Add it in help. Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn> --- tools/sched_ext/scx_qmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/sched_ext/scx_qmap.c b/tools/sched_ext/scx_qmap.c index e7c89a2bc3d8..b5fce6dcee14 100644 --- a/tools/sched_ext/scx_qmap.c +++ b/tools/sched_ext/scx_qmap.c @@ -32,6 +32,7 @@ const char help_fmt[] = " -P Print out DSQ content and event counters to trace_pipe every second\n" " -M Print out debug messages to trace_pipe\n" " -H Boost nice -20 tasks in SHARED_DSQ, use with -b\n" +" -c CG_PATH Cgroup path to attach as sub-scheduler, must run parent scheduler first\n" " -d PID Disallow a process from switching into SCHED_EXT (-1 for self)\n" " -D LEN Set scx_exit_info.dump buffer length\n" " -S Suppress qmap-specific debug dump\n" -- 2.43.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help 2026-04-15 9:54 ` [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help Zhao Mengmeng @ 2026-04-15 10:46 ` Cheng-Yang Chou 2026-04-15 10:48 ` Zhao mengmeng 0 siblings, 1 reply; 5+ messages in thread From: Cheng-Yang Chou @ 2026-04-15 10:46 UTC (permalink / raw) To: Zhao Mengmeng Cc: tj, void, arighi, changwoo, sched-ext, linux-kernel, zhaomengmeng, jserv, chia7712 Hi Zhao, On Wed, Apr 15, 2026 at 05:54:17PM +0800, Zhao Mengmeng wrote: > diff --git a/tools/sched_ext/scx_qmap.c b/tools/sched_ext/scx_qmap.c > index e7c89a2bc3d8..b5fce6dcee14 100644 > --- a/tools/sched_ext/scx_qmap.c > +++ b/tools/sched_ext/scx_qmap.c > @@ -32,6 +32,7 @@ const char help_fmt[] = > " -P Print out DSQ content and event counters to trace_pipe every second\n" > " -M Print out debug messages to trace_pipe\n" > " -H Boost nice -20 tasks in SHARED_DSQ, use with -b\n" > +" -c CG_PATH Cgroup path to attach as sub-scheduler, must run parent scheduler first\n" > " -d PID Disallow a process from switching into SCHED_EXT (-1 for self)\n" > " -D LEN Set scx_exit_info.dump buffer length\n" > " -S Suppress qmap-specific debug dump\n" Could you also add [-c CG_PATH] to the usage synopsis in help_fmt? Thanks! Reviewed-by: Cheng-Yang Chou <yphbchou0911@gmail.com> -- Thanks, Cheng-Yang ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help 2026-04-15 10:46 ` Cheng-Yang Chou @ 2026-04-15 10:48 ` Zhao mengmeng 0 siblings, 0 replies; 5+ messages in thread From: Zhao mengmeng @ 2026-04-15 10:48 UTC (permalink / raw) To: Cheng-Yang Chou Cc: tj, void, arighi, changwoo, sched-ext, linux-kernel, zhaomengmeng, jserv, chia7712 On April 15, 2026 6:46:22 PM GMT+08:00, Cheng-Yang Chou <yphbchou0911@gmail.com> wrote: >Hi Zhao, > >On Wed, Apr 15, 2026 at 05:54:17PM +0800, Zhao Mengmeng wrote: >> diff --git a/tools/sched_ext/scx_qmap.c b/tools/sched_ext/scx_qmap.c >> index e7c89a2bc3d8..b5fce6dcee14 100644 >> --- a/tools/sched_ext/scx_qmap.c >> +++ b/tools/sched_ext/scx_qmap.c >> @@ -32,6 +32,7 @@ const char help_fmt[] = >> " -P Print out DSQ content and event counters to trace_pipe every second\n" >> " -M Print out debug messages to trace_pipe\n" >> " -H Boost nice -20 tasks in SHARED_DSQ, use with -b\n" >> +" -c CG_PATH Cgroup path to attach as sub-scheduler, must run parent scheduler first\n" >> " -d PID Disallow a process from switching into SCHED_EXT (-1 for self)\n" >> " -D LEN Set scx_exit_info.dump buffer length\n" >> " -S Suppress qmap-specific debug dump\n" > >Could you also add [-c CG_PATH] to the usage synopsis in help_fmt? >Thanks! > >Reviewed-by: Cheng-Yang Chou <yphbchou0911@gmail.com> > OK, will do it. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] sched_ext: Print sub-scheduler disabled log and reason 2026-04-15 9:54 [PATCH 0/2] sched_ext: Cgroup sub-scheduler minor fixes Zhao Mengmeng 2026-04-15 9:54 ` [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help Zhao Mengmeng @ 2026-04-15 9:54 ` Zhao Mengmeng 1 sibling, 0 replies; 5+ messages in thread From: Zhao Mengmeng @ 2026-04-15 9:54 UTC (permalink / raw) To: tj, void, arighi, changwoo; +Cc: sched-ext, linux-kernel, zhaomengmeng From: Zhao Mengmeng <zhaomengmeng@kylinos.cn> Take scx_qmap for example, when sub scheduler is attached, there is 'BPF sub-scheduler "qmap" enabled' message, but when dettached, the log is missing. Add a new function to do the log thing, it can be used by both root scheduler and sub scheduler. Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn> --- kernel/sched/ext.c | 39 ++++++++++++++++++++++++--------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 012ca8bd70fb..229a82900e8f 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -5526,6 +5526,26 @@ static void scx_disable_dump(struct scx_sched *sch) sch->dump_disabled = true; } +static void scx_log_sched_disable(struct scx_sched *sch) +{ + struct scx_exit_info *ei = sch->exit_info; + const char *type = scx_parent(sch) ? "sub-scheduler" : "scheduler"; + + if (ei->kind >= SCX_EXIT_ERROR) { + pr_err("sched_ext: BPF %s \"%s\" disabled (%s)\n", type, + sch->ops.name, ei->reason); + + if (ei->msg[0] != '\0') + pr_err("sched_ext: %s: %s\n", sch->ops.name, ei->msg); +#ifdef CONFIG_STACKTRACE + stack_trace_print(ei->bt, ei->bt_len, 2); +#endif + } else { + pr_info("sched_ext: BPF %s \"%s\" disabled (%s)\n", type, + sch->ops.name, ei->reason); + } +} + #ifdef CONFIG_EXT_SUB_SCHED static DECLARE_WAIT_QUEUE_HEAD(scx_unlink_waitq); @@ -5696,6 +5716,8 @@ static void scx_sub_disable(struct scx_sched *sch) &sub_detach_args); } + scx_log_sched_disable(sch); + if (sch->ops.exit) SCX_CALL_OP(sch, exit, NULL, sch->exit_info); kobject_del(&sch->kobj); @@ -5707,7 +5729,6 @@ static void scx_sub_disable(struct scx_sched *sch) { } static void scx_root_disable(struct scx_sched *sch) { - struct scx_exit_info *ei = sch->exit_info; struct scx_task_iter sti; struct task_struct *p; int cpu; @@ -5797,22 +5818,10 @@ static void scx_root_disable(struct scx_sched *sch) scx_idle_disable(); synchronize_rcu(); - if (ei->kind >= SCX_EXIT_ERROR) { - pr_err("sched_ext: BPF scheduler \"%s\" disabled (%s)\n", - sch->ops.name, ei->reason); - - if (ei->msg[0] != '\0') - pr_err("sched_ext: %s: %s\n", sch->ops.name, ei->msg); -#ifdef CONFIG_STACKTRACE - stack_trace_print(ei->bt, ei->bt_len, 2); -#endif - } else { - pr_info("sched_ext: BPF scheduler \"%s\" disabled (%s)\n", - sch->ops.name, ei->reason); - } + scx_log_sched_disable(sch); if (sch->ops.exit) - SCX_CALL_OP(sch, exit, NULL, ei); + SCX_CALL_OP(sch, exit, NULL, sch->exit_info); scx_unlink_sched(sch); -- 2.43.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-15 10:49 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-04-15 9:54 [PATCH 0/2] sched_ext: Cgroup sub-scheduler minor fixes Zhao Mengmeng 2026-04-15 9:54 ` [PATCH 1/2] tools/sched_ext: Add missing -c option in scx_qmap help Zhao Mengmeng 2026-04-15 10:46 ` Cheng-Yang Chou 2026-04-15 10:48 ` Zhao mengmeng 2026-04-15 9:54 ` [PATCH 2/2] sched_ext: Print sub-scheduler disabled log and reason Zhao Mengmeng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®