From: Darren Salt <linux@youmustbejoking.demon.co.uk>
To: sfrench@samba.org
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [3.0-rc1] CIFS ACL build failure without CONFIG_KEYS
Date: Tue, 31 May 2011 17:23:54 +0000 [thread overview]
Message-ID: <51E1844698%linux@youmustbejoking.demon.co.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
In 3.0-rc1, without CONFIG_KEYS, cifs-acl.c compilation fails with various
errors, including one about trying to dereference an incomplete type (struct
keys, defined in <linux/key.h>).
I'm including two patches for this since I don't know which way to go on this
one: pick whichever is more correct :-)
--
| Darren Salt | linux or ds at | nr. Ashington, | _ ASCII ribbon
| using Debian | youmustbejoking | Northumberland | ( ) campaign against
| GNU/Linux | ,demon,co,uk | | X HTML e-mail
/ \ www.asciiribbon.org
Live every day like it's your last, because one day you'll be right.
[-- Attachment #2: cifs-acl-key-v1.patch --]
[-- Type: application/octet-stream, Size: 569 bytes --]
From: Darren Salt <linux@youmustbejoking.demon.co.uk>
Subject: CIFS ACL support needs CONFIG_KEYS, so select it
Signed-off-by: Darren Salt <linux@youmustbejoking.demon.co.uk>
--- a/fs/cifs/Kconfig.base 2011-05-30 01:43:36.000000000 +0100
+++ b/fs/cifs/Kconfig 2011-05-31 17:05:21.699421038 +0100
@@ -149,6 +149,7 @@
config CIFS_ACL
bool "Provide CIFS ACL support (EXPERIMENTAL)"
depends on EXPERIMENTAL && CIFS_XATTR
+ select KEYS
help
Allows to fetch CIFS/NTFS ACL from the server. The DACL blob
is handed over to the application/caller.
[-- Attachment #3: cifs-acl-key-v2.patch --]
[-- Type: application/octet-stream, Size: 653 bytes --]
From: Darren Salt <linux@youmustbejoking.demon.co.uk>
Subject: CIFS ACL support needs CONFIG_KEYS, so depend on it
Build fails if CONFIG_KEYS is not selected.
Signed-off-by: Darren Salt <linux@youmustbejoking.demon.co.uk>
--- a/fs/cifs/Kconfig.base 2011-05-30 01:43:36.000000000 +0100
+++ b/fs/cifs/Kconfig 2011-05-31 17:14:10.435870808 +0100
@@ -148,7 +148,7 @@
config CIFS_ACL
bool "Provide CIFS ACL support (EXPERIMENTAL)"
- depends on EXPERIMENTAL && CIFS_XATTR
+ depends on EXPERIMENTAL && CIFS_XATTR && KEYS
help
Allows to fetch CIFS/NTFS ACL from the server. The DACL blob
is handed over to the application/caller.
next reply other threads:[~2011-05-31 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 17:23 Darren Salt [this message]
2011-06-06 16:58 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E1844698%linux@youmustbejoking.demon.co.uk \
--to=linux@youmustbejoking.demon.co.uk \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®