[3.0-rc1] CIFS ACL build failure without CONFIG_KEYS

[3.0-rc1] CIFS ACL build failure without CONFIG_KEYS

[Darren Salt]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

In 3.0-rc1, without CONFIG_KEYS, cifs-acl.c compilation fails with various
errors, including one about trying to dereference an incomplete type (struct
keys, defined in <linux/key.h>).

I'm including two patches for this since I don't know which way to go on this
one: pick whichever is more correct :-)

-- 
| Darren Salt  | linux or ds at  | nr. Ashington, |  _  ASCII ribbon
| using Debian | youmustbejoking | Northumberland | ( ) campaign against
| GNU/Linux    | ,demon,co,uk    |                |  X  HTML e-mail
                                                    / \ www.asciiribbon.org
Live every day like it's your last, because one day you'll be right.


[-- Attachment #2: cifs-acl-key-v1.patch --]
[-- Type: application/octet-stream, Size: 569 bytes --]

From: Darren Salt <linux@youmustbejoking.demon.co.uk>
Subject: CIFS ACL support needs CONFIG_KEYS, so select it

Signed-off-by: Darren Salt <linux@youmustbejoking.demon.co.uk>

--- a/fs/cifs/Kconfig.base	2011-05-30 01:43:36.000000000 +0100
+++ b/fs/cifs/Kconfig	2011-05-31 17:05:21.699421038 +0100
@@ -149,6 +149,7 @@
 config CIFS_ACL
 	  bool "Provide CIFS ACL support (EXPERIMENTAL)"
 	  depends on EXPERIMENTAL && CIFS_XATTR
+	  select KEYS
 	  help
 	    Allows to fetch CIFS/NTFS ACL from the server.  The DACL blob
 	    is handed over to the application/caller.

[-- Attachment #3: cifs-acl-key-v2.patch --]
[-- Type: application/octet-stream, Size: 653 bytes --]

From: Darren Salt <linux@youmustbejoking.demon.co.uk>
Subject: CIFS ACL support needs CONFIG_KEYS, so depend on it

Build fails if CONFIG_KEYS is not selected.

Signed-off-by: Darren Salt <linux@youmustbejoking.demon.co.uk>

--- a/fs/cifs/Kconfig.base	2011-05-30 01:43:36.000000000 +0100
+++ b/fs/cifs/Kconfig	2011-05-31 17:14:10.435870808 +0100
@@ -148,7 +148,7 @@
 
 config CIFS_ACL
 	  bool "Provide CIFS ACL support (EXPERIMENTAL)"
-	  depends on EXPERIMENTAL && CIFS_XATTR
+	  depends on EXPERIMENTAL && CIFS_XATTR && KEYS
 	  help
 	    Allows to fetch CIFS/NTFS ACL from the server.  The DACL blob
 	    is handed over to the application/caller.

Re: [3.0-rc1] CIFS ACL build failure without CONFIG_KEYS

[Steve French]

I merged the 2nd of the two.

On Tue, May 31, 2011 at 12:23 PM, Darren Salt
<linux@youmustbejoking.demon.co.uk> wrote:
> In 3.0-rc1, without CONFIG_KEYS, cifs-acl.c compilation fails with various
> errors, including one about trying to dereference an incomplete type (struct
> keys, defined in <linux/key.h>).
>
> I'm including two patches for this since I don't know which way to go on this
> one: pick whichever is more correct :-)
>
> --
> | Darren Salt  | linux or ds at  | nr. Ashington, |  _  ASCII ribbon
> | using Debian | youmustbejoking | Northumberland | ( ) campaign against
> | GNU/Linux    | ,demon,co,uk    |                |  X  HTML e-mail
>                                                    / \ www.asciiribbon.org
> Live every day like it's your last, because one day you'll be right.
>
>



-- 
Thanks,

Steve