mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Lyude <lyude@redhat.com>, amd-gfx@lists.freedesktop.org
Cc: "David Airlie" <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code
Date: Sat, 20 May 2017 13:39:42 +0200	[thread overview]
Message-ID: <51a14f4e-8771-3bca-b05f-25732da50b34@vodafone.de> (raw)
In-Reply-To: <20170519234840.5644-1-lyude@redhat.com>

Am 20.05.2017 um 01:48 schrieb Lyude:
> This is the first part of me going through and cleaning up the IRQ handling
> code for radeon, since after taking a look at it the other day while trying to
> debug something I realized basically all of the code was copy pasted
> everywhere, and quite difficult to actually read through.
>
> Will come up with something for r600 and cik once I've got the chipsets on hand
> to test with.
>
> Lyude (3):
>    drm/radeon: Cleanup display interrupt handling for evergreen, si
>    drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
>    drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si

I don't have time to do a line by line review, but what I saw looked 
very good to me.

So the whole seres is Acked-by: Christian König <christian.koenig@amd.com>.

BTW: You don't want to take a look at the other hw generations as well?

Regards,
Christian.

>
>   drivers/gpu/drm/radeon/evergreen.c      | 943 ++++++--------------------------
>   drivers/gpu/drm/radeon/radeon.h         |  27 +-
>   drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
>   drivers/gpu/drm/radeon/si.c             | 655 +++++-----------------
>   4 files changed, 344 insertions(+), 1316 deletions(-)
>

  parent reply	other threads:[~2017-05-20 11:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16 21:11 [PATCH " Lyude
2017-05-16 21:11 ` [PATCH 1/3] drm/radeon: Cleanup display interrupt handling for evergreen, si Lyude
2017-05-16 21:11 ` [PATCH 2/3] drm/radeon: Cleanup HDMI audio interrupt handling for evergreen Lyude
2017-05-16 21:12 ` [PATCH 3/3] drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si Lyude
2017-05-17  8:32 ` [PATCH 0/3] Cleanup evergreen/si IRQ handling code Christian König
2017-05-19 23:48 ` [PATCH v2 " Lyude
2017-05-19 23:48   ` [PATCH v2 1/3] drm/radeon: Cleanup display interrupt handling for evergreen, si Lyude
2017-05-19 23:48   ` [PATCH v2 2/3] drm/radeon: Cleanup HDMI audio interrupt handling for evergreen Lyude
2017-05-19 23:48   ` [PATCH v2 3/3] drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si Lyude
2017-05-20 11:39   ` Christian König [this message]
2017-05-22 13:52     ` [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code Lyude Paul
2017-05-24 18:31     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51a14f4e-8771-3bca-b05f-25732da50b34@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®