From: Paul Moore <paul@paul-moore.com>
To: Oliwier Iwan <oliwieriwan@mailbox.org>, selinux@vger.kernel.org
Cc: stephen.smalley.work@gmail.com, omosnace@redhat.com,
linux-kernel@vger.kernel.org,
Oliwier Iwan <oliwieriwan@mailbox.org>
Subject: Re: [PATCH] selinux: add comments to smp_wmb() calls in status.c
Date: Wed, 27 May 2026 20:05:52 -0400 [thread overview]
Message-ID: <51a1cbe14d3ed32b303d6ed95a69c155@paul-moore.com> (raw)
In-Reply-To: <20260521223815.67902-1-oliwieriwan@mailbox.org>
On May 21, 2026 Oliwier Iwan <oliwieriwan@mailbox.org> wrote:
>
> The seqlock pattern used in selinux_status_update_setenforce() and
> selinux_status_update_policyload() requires memory barriers to ensure
> correct ordering of the sequence counter updates relative to the data
> writes. Add comments to the smp_wmb() calls to make this ordering
> explicit and self-documenting.
>
> Signed-off-by: Oliwier Iwan <oliwieriwan@mailbox.org>
> ---
> security/selinux/status.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Thank you for submitting a patch, but I don't believe the comments are
necessary.
--
paul-moore.com
prev parent reply other threads:[~2026-05-28 0:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 22:38 Oliwier Iwan
2026-05-28 0:05 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51a1cbe14d3ed32b303d6ed95a69c155@paul-moore.com \
--to=paul@paul-moore.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliwieriwan@mailbox.org \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®