[Q] 2.4.6 compatibility cruft in 8250_pci.c

[Q] 2.4.6 compatibility cruft in 8250_pci.c

[Andrey Panin]

Hello all,

do we really need these lines now ?

/* 2.4.6 compatinility cruft ... */
#define pci_board __pci_board
#include <serialP.h>
#undef pci_board

I'm trying to forward port a patch moving SIIG combo cards support
from serial driver into parport_serial.c and these lines are on my
way :)

Re: [Q] 2.4.6 compatibility cruft in 8250_pci.c

[Andrey Panin]

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

On Птн, Окт 11, 2002 at 01:27:23 +0100, Russell King wrote:
> On Wed, Oct 09, 2002 at 07:41:43AM +0400, Andrey Panin wrote:
> > Ugh, this is not what i need. I want to move SIIG combo cards support
> > from 8250_pci.c to parport_serial.c module. For this I need to export
> > pci_siig[12]0x_fn() functions having struct pci_board *board as one
> > of arguments. parport_serial.c modules already includes
> > <linux/serialP.h> so used it for 2.4, but 2.5 is different.
> 
> Well, I'd like to eliminate struct pci_board from the init functions
> for several reasons.  One of them is that some of the init functions
> do buggy things with it (like increasing the number of ports.)
> 
> This should solve your problem - please confirm.
>
Yes it should fix my problem, actually SIIG initialization functions don't
even use this argument.

When you submit this change to 2.5 I'll send a patch ASAP.

Best regards.

-- 
Andrey Panin            | Embedded systems software engineer
pazke@orbita1.ru        | PGP key: wwwkeys.eu.pgp.net

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]