* [PATCH] media: vb2 vmalloc: Constify dma_buf_ops structures. @ 2017-07-01 11:37 ` Arvind Yadav 2017-07-04 5:23 ` Marek Szyprowski 0 siblings, 1 reply; 2+ messages in thread From: Arvind Yadav @ 2017-07-01 11:37 UTC (permalink / raw) To: pawel, m.szyprowski, kyungmin.park, mchehab; +Cc: linux-media, linux-kernel dma_buf_ops are not supposed to change at runtime. All functions working with dma_buf_ops provided by <linux/dma-buf.h> work with const dma_buf_ops. So mark the non-const structs as const. File size before: text data bss dec hex filename 3171 192 0 3363 d23 drivers/media/v4l2-core/videobuf2-vmalloc.o File size After adding 'const': text data bss dec hex filename 3291 80 0 3371 d2b drivers/media/v4l2-core/videobuf2-vmalloc.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/media/v4l2-core/videobuf2-vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c b/drivers/media/v4l2-core/videobuf2-vmalloc.c index b337d78..6bc130f 100644 --- a/drivers/media/v4l2-core/videobuf2-vmalloc.c +++ b/drivers/media/v4l2-core/videobuf2-vmalloc.c @@ -338,7 +338,7 @@ static int vb2_vmalloc_dmabuf_ops_mmap(struct dma_buf *dbuf, return vb2_vmalloc_mmap(dbuf->priv, vma); } -static struct dma_buf_ops vb2_vmalloc_dmabuf_ops = { +static const struct dma_buf_ops vb2_vmalloc_dmabuf_ops = { .attach = vb2_vmalloc_dmabuf_ops_attach, .detach = vb2_vmalloc_dmabuf_ops_detach, .map_dma_buf = vb2_vmalloc_dmabuf_ops_map, -- 2.7.4 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: vb2 vmalloc: Constify dma_buf_ops structures. 2017-07-01 11:37 ` [PATCH] media: vb2 vmalloc: Constify dma_buf_ops structures Arvind Yadav @ 2017-07-04 5:23 ` Marek Szyprowski 0 siblings, 0 replies; 2+ messages in thread From: Marek Szyprowski @ 2017-07-04 5:23 UTC (permalink / raw) To: Arvind Yadav, pawel, kyungmin.park, mchehab; +Cc: linux-media, linux-kernel Hi Arvind, On 2017-07-01 13:37, Arvind Yadav wrote: > dma_buf_ops are not supposed to change at runtime. All functions > working with dma_buf_ops provided by <linux/dma-buf.h> work with > const dma_buf_ops. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 3171 192 0 3363 d23 drivers/media/v4l2-core/videobuf2-vmalloc.o > > File size After adding 'const': > text data bss dec hex filename > 3291 80 0 3371 d2b drivers/media/v4l2-core/videobuf2-vmalloc.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/media/v4l2-core/videobuf2-vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c b/drivers/media/v4l2-core/videobuf2-vmalloc.c > index b337d78..6bc130f 100644 > --- a/drivers/media/v4l2-core/videobuf2-vmalloc.c > +++ b/drivers/media/v4l2-core/videobuf2-vmalloc.c > @@ -338,7 +338,7 @@ static int vb2_vmalloc_dmabuf_ops_mmap(struct dma_buf *dbuf, > return vb2_vmalloc_mmap(dbuf->priv, vma); > } > > -static struct dma_buf_ops vb2_vmalloc_dmabuf_ops = { > +static const struct dma_buf_ops vb2_vmalloc_dmabuf_ops = { > .attach = vb2_vmalloc_dmabuf_ops_attach, > .detach = vb2_vmalloc_dmabuf_ops_detach, > .map_dma_buf = vb2_vmalloc_dmabuf_ops_map, Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-04 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170701113746epcas3p3f76bbf5988c9d31e3a781c6b0efd8e08@epcas3p3.samsung.com>
2017-07-01 11:37 ` [PATCH] media: vb2 vmalloc: Constify dma_buf_ops structures Arvind Yadav
2017-07-04 5:23 ` Marek Szyprowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®