From: Stephen Warren <swarren@wwwdotorg.org>
To: Fabian Vogt <fabian@ritter-vogt.de>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
linus.walleij@linaro.org, grant.likely@linaro.org,
pawel.moll@arm.com, rob.herring@calxeda.com,
mark.rutland@arm.com, ian.campbell@citrix.com
Subject: Re: [PATCH V5] gpio: New driver for LSI ZEVIO SoCs
Date: Tue, 27 Aug 2013 14:09:39 -0600 [thread overview]
Message-ID: <521D0783.9000804@wwwdotorg.org> (raw)
In-Reply-To: <1377541133-7427-1-git-send-email-fabian@ritter-vogt.de>
On 08/26/2013 12:18 PM, Fabian Vogt wrote:
> This driver supports the GPIO controller found in LSI ZEVIO SoCs.
> It has been successfully tested on a TI nspire CX calculator.
What changed in v5 (or indeed any other versions?)
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
> +Zevio GPIO controller
> +
> +Required properties:
> +- compatible = "lsi,zevio-gpio"
> +- reg = <BASEADDR SIZE>
Perhaps this should say:
reg: Contains a single register specifier for the GPIO module's registers.
> +- #gpio-cells = <2>
This should describe what those cells are. For example perhaps:
#gpio-cells. Must be 2. The first cell is the GPIO number. The second
cell is used to specify optional parameters:
- bit 0 specifies polarity (0 for normal, 1 for inverted)
next prev parent reply other threads:[~2013-08-27 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 18:18 Fabian Vogt
2013-08-27 20:09 ` Stephen Warren [this message]
2013-08-29 18:30 ` Linus Walleij
2013-08-29 20:28 ` Fabian Vogt
2013-08-29 20:29 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521D0783.9000804@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=fabian@ritter-vogt.de \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®