mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Fabian Vogt <vogtinator@myopera.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V5] gpio: New driver for LSI ZEVIO SoCs
Date: Thu, 29 Aug 2013 14:29:32 -0600	[thread overview]
Message-ID: <521FAF2C.5070606@wwwdotorg.org> (raw)
In-Reply-To: <op.w2lhuicjfdrgmf@fabians-laptop.fritz.box>

On 08/29/2013 02:28 PM, Fabian Vogt wrote:
>> On 08/26/2013 12:18 PM, Fabian Vogt wrote:
>>> This driver supports the GPIO controller found in LSI ZEVIO SoCs.
>>> It has been successfully tested on a TI nspire CX calculator.

>>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
>>> b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt

>>> +- #gpio-cells = <2>
>> This should describe what those cells are. For example perhaps:
>>
>> #gpio-cells. Must be 2. The first cell is the GPIO number. The second
>>  cell is used to specify optional parameters:
>>  - bit 0 specifies polarity (0 for normal, 1 for inverted)
>
> "Must be 2. The second cell is ... optional"?

I'm not sure what your question is, but perhaps this will answer it:

The 2nd cell isn't optional, but setting the various flags within the
cell is optional.

      reply	other threads:[~2013-08-29 20:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 18:18 Fabian Vogt
2013-08-27 20:09 ` Stephen Warren
2013-08-29 18:30 ` Linus Walleij
2013-08-29 20:28   ` Fabian Vogt
2013-08-29 20:29     ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521FAF2C.5070606@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=vogtinator@myopera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®