From: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
To: Johan Hovold <johan@kernel.org>,
"Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Cc: Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()
Date: Mon, 30 Oct 2017 11:44:22 +0000 [thread overview]
Message-ID: <523e9618-e72e-72fa-3d98-062e687ca226@linaro.org> (raw)
In-Reply-To: <20171030113819.GD7223@localhost>
On 30/10/17 11:38, Johan Hovold wrote:
> On Mon, Oct 30, 2017 at 11:35:50AM +0000, Bryan O'Donoghue wrote:
>> On 30/10/17 11:32, Johan Hovold wrote:
>>> The right thing to do here is to respin your patch from last year which
>>> converts the loopback driver to use the timeout handling in greybus
>>> core.
>>
>> Actually I wasn't clear if you wanted to to that yourself aswell as the
>> rest if it.
>>
>> But sure I can do that conversion, it's on my list.
>
> IIRC it was basically done. Just some odd locking that could now also be
> removed.
>
> Thanks,
> Johan
>
I think once Kees' change is applied to operation.c and we convert the
async stuff to operation.c's callbacks there ought to be no use of
timers, linked lists of operations.
I'll probably need at least a day to look at that, so it'll be the
weekend before I can really allocate time.
---
bod
next prev parent reply other threads:[~2017-10-30 11:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 14:49 Kees Cook
2017-10-24 15:54 ` Bryan O'Donoghue
2017-10-30 11:32 ` Johan Hovold
2017-10-30 11:35 ` Bryan O'Donoghue
2017-10-30 11:38 ` Johan Hovold
2017-10-30 11:44 ` Bryan O'Donoghue [this message]
2017-10-30 11:48 ` Johan Hovold
2017-10-30 21:37 ` Kees Cook
2017-10-31 0:01 ` pure.logic
2017-10-31 0:05 ` Kees Cook
2017-11-03 20:21 ` Kees Cook
2017-11-03 21:49 ` Bryan O'Donoghue
2017-11-03 21:49 ` Kees Cook
2017-10-30 11:35 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523e9618-e72e-72fa-3d98-062e687ca226@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®