mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Steve French" <smfrench@gmail.com>
To: "Randy Dunlap" <randy.dunlap@oracle.com>
Cc: "Stephen Rothwell" <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	sfrench@samba.org, "Greg KH" <gregkh@suse.de>
Subject: Re: linux-next: Tree for January 12 (cifs vs. staging)
Date: Mon, 12 Jan 2009 12:58:42 -0600	[thread overview]
Message-ID: <524f69650901121058g73c8022eif1d1bcca5c0e01fa@mail.gmail.com> (raw)
In-Reply-To: <496B899E.7060605@oracle.com>

There is not just the cifs md5 one (which has been around a long
time), but an md5_init (static) in crypto and the new one in rt.  The
addition of the new one (rt md5_init) causes the build problem.   It
would be nice if we could use the same md5 routines though ... last
time we checked the crypto one was not well suited for calculating
signatures as a network fs would do though.

On Mon, Jan 12, 2009 at 12:19 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> Stephen Rothwell wrote:
>> Hi all,
>>
>> Some people took me at my word and so we have the 2.6.30 code starting to
>> trickle in already.
>
>
>
> When CIFS is built-in (=y) and staging/rt28[67]0 =y, there are multiple
> definitions of:
>
> build-r8250.out:(.text+0x1d8ad0): multiple definition of `MD5Init'
> build-r8250.out:(.text+0x1dbb30): multiple definition of `MD5Update'
> build-r8250.out:(.text+0x1db9b0): multiple definition of `MD5Final'
>
> all of which need to have more unique identifiers for their global
> symbols (e.g., rt28_md5_init, cifs_md5_init, foo, blah, bar).
>
>
> --
> ~Randy
>



-- 
Thanks,

Steve

  reply	other threads:[~2009-01-12 18:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12  4:45 linux-next: Tree for January 12 Stephen Rothwell
2009-01-12 18:19 ` linux-next: Tree for January 12 (cifs vs. staging) Randy Dunlap
2009-01-12 18:58   ` Steve French [this message]
2009-01-12 19:13     ` Greg KH
2009-01-12 19:23       ` Steve French
2009-01-12 19:32         ` Greg KH
2009-01-12 20:13           ` Steve French
2009-01-12 20:21             ` Greg KH
2009-01-12 20:40               ` Steve French
2009-01-12 21:07       ` Steve French
2009-01-13  2:01         ` Valdis.Kletnieks
2009-01-13  2:27           ` Dave Kleikamp
2009-01-13  2:35             ` Valdis.Kletnieks
2009-01-12 19:19     ` Dave Kleikamp
2009-01-12 19:23       ` Greg KH
2009-01-12 19:35       ` Steve French
2009-01-12 18:50 ` [PATCH -next] libfc: needs CRC32 Randy Dunlap
2009-01-13  0:05   ` Love, Robert W
2009-01-12 18:53 ` [PATCH -next] scsi_debug: needs CRC_T10DIF Randy Dunlap
2009-01-13  3:26   ` Martin K. Petersen
2009-01-12 19:08 ` linux-next: Tree for January 12 (afs/fscache) Randy Dunlap
2009-01-13  6:35 linux-next: Tree for January 12 (cifs vs. staging) Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524f69650901121058g73c8022eif1d1bcca5c0e01fa@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sfrench@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®