* [PATCH] iscsi_iser: Add missing newlines to logging messages
@ 2013-10-07 22:44 Joe Perches
2013-10-08 5:44 ` Or Gerlitz
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2013-10-07 22:44 UTC (permalink / raw)
To: Or Gerlitz, Roi Dayan, Roland Dreier, Sean Hefty, Hal Rosenstock
Cc: linux-rdma, LKML
Logging messages need terminating newlines to avoid
possible message interleaving. Add them.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index dd03cfe..dfb62e3 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -481,28 +481,28 @@ iscsi_iser_set_param(struct iscsi_cls_conn *cls_conn,
case ISCSI_PARAM_HDRDGST_EN:
sscanf(buf, "%d", &value);
if (value) {
- iser_err("DataDigest wasn't negotiated to None");
+ iser_err("DataDigest wasn't negotiated to None\n");
return -EPROTO;
}
break;
case ISCSI_PARAM_DATADGST_EN:
sscanf(buf, "%d", &value);
if (value) {
- iser_err("DataDigest wasn't negotiated to None");
+ iser_err("DataDigest wasn't negotiated to None\n");
return -EPROTO;
}
break;
case ISCSI_PARAM_IFMARKER_EN:
sscanf(buf, "%d", &value);
if (value) {
- iser_err("IFMarker wasn't negotiated to No");
+ iser_err("IFMarker wasn't negotiated to No\n");
return -EPROTO;
}
break;
case ISCSI_PARAM_OFMARKER_EN:
sscanf(buf, "%d", &value);
if (value) {
- iser_err("OFMarker wasn't negotiated to No");
+ iser_err("OFMarker wasn't negotiated to No\n");
return -EPROTO;
}
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iscsi_iser: Add missing newlines to logging messages
2013-10-07 22:44 [PATCH] iscsi_iser: Add missing newlines to logging messages Joe Perches
@ 2013-10-08 5:44 ` Or Gerlitz
0 siblings, 0 replies; 2+ messages in thread
From: Or Gerlitz @ 2013-10-08 5:44 UTC (permalink / raw)
To: Joe Perches
Cc: Roi Dayan, Roland Dreier, Sean Hefty, Hal Rosenstock, linux-rdma, LKML
On 08/10/2013 01:44, Joe Perches wrote:
> Logging messages need terminating newlines to avoid
> possible message interleaving. Add them.
>
> Signed-off-by: Joe Perches<joe@perches.com>
> ---
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-08 5:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-07 22:44 [PATCH] iscsi_iser: Add missing newlines to logging messages Joe Perches
2013-10-08 5:44 ` Or Gerlitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®