mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist
@ 2024-01-17 12:14 Daniel Abrecht
  2024-01-17 12:20 ` Jaroslav Kysela
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Abrecht @ 2024-01-17 12:14 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	linux-sound, linux-kernel

In U-Boot, the default for DMI vendor / product if not set is "Unknown" 
and "Unknown Product".
See 
https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272

This patch adds them to the dmi_blacklist.

Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>
---
  sound/soc/soc-core.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index f8524b5bfb33..aa1a31abbe3a 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1804,6 +1804,8 @@ static const char * const dmi_blacklist[] = {
      "Board Manufacturer",
      "Board Vendor Name",
      "Board Product Name",
+    "Unknown",
+    "Unknown Product",
      NULL,    /* terminator */
  };

-- 
2.39.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist
  2024-01-17 12:14 [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist Daniel Abrecht
@ 2024-01-17 12:20 ` Jaroslav Kysela
  2024-01-17 13:43   ` Daniel Abrecht
  0 siblings, 1 reply; 3+ messages in thread
From: Jaroslav Kysela @ 2024-01-17 12:20 UTC (permalink / raw)
  To: Daniel Abrecht, Liam Girdwood, Mark Brown, Takashi Iwai,
	linux-sound, linux-kernel

On 17. 01. 24 13:14, Daniel Abrecht wrote:
> In U-Boot, the default for DMI vendor / product if not set is "Unknown"
> and "Unknown Product".
> See
> https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272
> 
> This patch adds them to the dmi_blacklist.
> 
> Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>

I think that there's a whitespace issue, but for the contents:

Acked-by: Jaroslav Kysela <perex@perex.cz>


> ---
>    sound/soc/soc-core.c | 2 ++
>    1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index f8524b5bfb33..aa1a31abbe3a 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1804,6 +1804,8 @@ static const char * const dmi_blacklist[] = {
>        "Board Manufacturer",
>        "Board Vendor Name",
>        "Board Product Name",
> +    "Unknown",
> +    "Unknown Product",
>        NULL,    /* terminator */
>    };
> 

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist
  2024-01-17 12:20 ` Jaroslav Kysela
@ 2024-01-17 13:43   ` Daniel Abrecht
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Abrecht @ 2024-01-17 13:43 UTC (permalink / raw)
  To: Jaroslav Kysela
  Cc: Liam Girdwood, Mark Brown, Takashi Iwai, linux-sound, linux-kernel

Am 2024-01-17 13:20, schrieb Jaroslav Kysela:
> On 17. 01. 24 13:14, Daniel Abrecht wrote:
>> In U-Boot, the default for DMI vendor / product if not set is 
>> "Unknown"
>> and "Unknown Product".
>> See
>> https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272
>> 
>> This patch adds them to the dmi_blacklist.
>> 
>> Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>
> 
> I think that there's a whitespace issue, but for the contents:
> 
> Acked-by: Jaroslav Kysela <perex@perex.cz>

Sorry about the whitespace thing. I'll try again.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-17 13:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-17 12:14 [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist Daniel Abrecht
2024-01-17 12:20 ` Jaroslav Kysela
2024-01-17 13:43   ` Daniel Abrecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®