* [f2fs-dev][PATCH] f2fs: fix a potential out of range issue
@ 2013-11-26 8:44 Gu Zheng
0 siblings, 0 replies; only message in thread
From: Gu Zheng @ 2013-11-26 8:44 UTC (permalink / raw)
To: Kim; +Cc: f2fs, fsdevel, linux-kernel
Fix a potential out of range issue introduced by commit:
22fb72225a
f2fs: simplify write_orphan_inodes for better readable
Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
---
fs/f2fs/checkpoint.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 7fe69ff..3e62987 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -323,9 +323,9 @@ static void write_orphan_inodes(struct f2fs_sb_info *sbi, block_t start_blk)
memset(orphan_blk, 0, sizeof(*orphan_blk));
}
- orphan_blk->ino[nentries] = cpu_to_le32(orphan->ino);
+ orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
- if (nentries++ == F2FS_ORPHANS_PER_BLOCK) {
+ if (nentries == F2FS_ORPHANS_PER_BLOCK) {
/*
* an orphan block is full of 1020 entries,
* then we need to flush current orphan blocks
--
1.7.7
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-11-26 8:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-26 8:44 [f2fs-dev][PATCH] f2fs: fix a potential out of range issue Gu Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome