[PATCH v4 0/2] Setup panic params early

[PATCH v4 0/2] Setup panic params early

[Felipe Contreras]

Exactly the same as v3, but with an unlrelated patch on top as well.

Felipe Contreras (2):
  panic: setup panic_timeout early
  panic: setup panic_on_oops early

 kernel/panic.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

-- 
1.8.4.2+fc1

[PATCH v4 1/2] panic: setup panic_timeout early

[Felipe Contreras]

Otherwise we might not reboot when the user needs it the most (early
on).

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 kernel/panic.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index b6c482c..3456652 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -468,9 +468,14 @@ EXPORT_SYMBOL(__stack_chk_fail);
 
 #endif
 
-core_param(panic, panic_timeout, int, 0644);
 core_param(pause_on_oops, pause_on_oops, int, 0644);
 
+static int __init set_panic_timeout(char *val)
+{
+	return kstrtoint(val, 0, &panic_timeout);
+}
+early_param("panic_timeout", set_panic_timeout);
+
 static int __init oops_setup(char *s)
 {
 	if (!s)
-- 
1.8.4.2+fc1

[PATCH v4 2/2] panic: setup panic_on_oops early

[Felipe Contreras]

For consistency.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 kernel/panic.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 3456652..2256838 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -468,7 +468,11 @@ EXPORT_SYMBOL(__stack_chk_fail);
 
 #endif
 
-core_param(pause_on_oops, pause_on_oops, int, 0644);
+static int __init set_panic_on_oops(char *val)
+{
+	return kstrtoint(val, 0, &panic_on_oops);
+}
+early_param("panic_on_oops", set_panic_on_oops);
 
 static int __init set_panic_timeout(char *val)
 {
-- 
1.8.4.2+fc1

Re: [PATCH v4 1/2] panic: setup panic_timeout early

[Jason Baron]

On 11/27/2013 01:17 AM, Felipe Contreras wrote:
> Otherwise we might not reboot when the user needs it the most (early
> on).
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  kernel/panic.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index b6c482c..3456652 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -468,9 +468,14 @@ EXPORT_SYMBOL(__stack_chk_fail);
>  
>  #endif
>  
> -core_param(panic, panic_timeout, int, 0644);
>  core_param(pause_on_oops, pause_on_oops, int, 0644);
>  
> +static int __init set_panic_timeout(char *val)
> +{
> +	return kstrtoint(val, 0, &panic_timeout);
> +}
> +early_param("panic_timeout", set_panic_timeout);
> +
>  static int __init oops_setup(char *s)
>  {
>  	if (!s)

hmm....so this changes the comand-line parameter panic=x  to:
panic_timeout=x. The naming might not be the best, but we are
really stuck with it at this point.

Thanks,

-Jason
 

Re: [PATCH v4 1/2] panic: setup panic_timeout early

[Felipe Contreras]

On Wed, Nov 27, 2013 at 9:47 AM, Jason Baron <jbaron@akamai.com> wrote:
> On 11/27/2013 01:17 AM, Felipe Contreras wrote:
>> Otherwise we might not reboot when the user needs it the most (early
>> on).
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> ---
>>  kernel/panic.c | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/panic.c b/kernel/panic.c
>> index b6c482c..3456652 100644
>> --- a/kernel/panic.c
>> +++ b/kernel/panic.c
>> @@ -468,9 +468,14 @@ EXPORT_SYMBOL(__stack_chk_fail);
>>
>>  #endif
>>
>> -core_param(panic, panic_timeout, int, 0644);
>>  core_param(pause_on_oops, pause_on_oops, int, 0644);
>>
>> +static int __init set_panic_timeout(char *val)
>> +{
>> +     return kstrtoint(val, 0, &panic_timeout);
>> +}
>> +early_param("panic_timeout", set_panic_timeout);
>> +
>>  static int __init oops_setup(char *s)
>>  {
>>       if (!s)
>
> hmm....so this changes the comand-line parameter panic=x  to:
> panic_timeout=x. The naming might not be the best, but we are
> really stuck with it at this point.

Hmm, right, it should be "panic".

-- 
Felipe Contreras