From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: Chris Ruehl <chris.ruehl@gtsys.com.hk>
Cc: balbi@ti.com, gregkh@linuxfoundation.org, swarren@wwwdotorg.org,
thierry.reding@gmail.com, linux-usb@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
Date: Wed, 04 Dec 2013 10:02:23 +0800 [thread overview]
Message-ID: <529E8D2F.3070706@gtsys.com.hk> (raw)
In-Reply-To: <1386122435-4205-1-git-send-email-chris.ruehl@gtsys.com.hk>
Sorry for the noise, it should be [PATCH] only .. I will resend it.
On Wednesday, December 04, 2013 10:00 AM, Chris Ruehl wrote:
> usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
>
> A wrong pointer was used to test the result of devm_ioremap()
>
> Signed-off-by: Chris Ruehl<chris.ruehl@gtsys.com.hk>
> Acked-by: Venu Byravarasu<vbyravarasu@nvidia.com>
> ---
> drivers/usb/phy/phy-tegra-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
> index 82232ac..bbe4f8e 100644
> --- a/drivers/usb/phy/phy-tegra-usb.c
> +++ b/drivers/usb/phy/phy-tegra-usb.c
> @@ -876,7 +876,7 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy,
>
> tegra_phy->pad_regs = devm_ioremap(&pdev->dev, res->start,
> resource_size(res));
> - if (!tegra_phy->regs) {
> + if (!tegra_phy->pad_regs) {
> dev_err(&pdev->dev, "Failed to remap UTMI Pad regs\n");
> return -ENOMEM;
> }
--
GTSYS Limited RFID Technology
A01 24/F Gold King Industrial Bld
35-41 Tai Lin Pai Road, Kwai Chung, Hong Kong
Fax (852) 8167 4060 - Tel (852) 3598 9488
Disclaimer: http://www.gtsys.com.hk/email/classified.html
prev parent reply other threads:[~2013-12-04 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 2:00 Chris Ruehl
2013-12-04 2:02 ` Chris Ruehl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E8D2F.3070706@gtsys.com.hk \
--to=chris.ruehl@gtsys.com.hk \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®