mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
@ 2013-12-04  2:00 Chris Ruehl
  2013-12-04  2:02 ` Chris Ruehl
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Ruehl @ 2013-12-04  2:00 UTC (permalink / raw)
  To: balbi
  Cc: gregkh, swarren, thierry.reding, linux-usb, linux-tegra,
	linux-kernel, Chris Ruehl

usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

A wrong pointer was used to test the result of devm_ioremap()

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
Acked-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---
 drivers/usb/phy/phy-tegra-usb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index 82232ac..bbe4f8e 100644
--- a/drivers/usb/phy/phy-tegra-usb.c
+++ b/drivers/usb/phy/phy-tegra-usb.c
@@ -876,7 +876,7 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy,
 
 	tegra_phy->pad_regs = devm_ioremap(&pdev->dev, res->start,
 		resource_size(res));
-	if (!tegra_phy->regs) {
+	if (!tegra_phy->pad_regs) {
 		dev_err(&pdev->dev, "Failed to remap UTMI Pad regs\n");
 		return -ENOMEM;
 	}
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
  2013-12-04  2:00 [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI Chris Ruehl
@ 2013-12-04  2:02 ` Chris Ruehl
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Ruehl @ 2013-12-04  2:02 UTC (permalink / raw)
  To: Chris Ruehl
  Cc: balbi, gregkh, swarren, thierry.reding, linux-usb, linux-tegra,
	linux-kernel

Sorry for the noise, it should be [PATCH] only .. I will resend it.


On Wednesday, December 04, 2013 10:00 AM, Chris Ruehl wrote:
> usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
>
> A wrong pointer was used to test the result of devm_ioremap()
>
> Signed-off-by: Chris Ruehl<chris.ruehl@gtsys.com.hk>
> Acked-by: Venu Byravarasu<vbyravarasu@nvidia.com>
> ---
>   drivers/usb/phy/phy-tegra-usb.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
> index 82232ac..bbe4f8e 100644
> --- a/drivers/usb/phy/phy-tegra-usb.c
> +++ b/drivers/usb/phy/phy-tegra-usb.c
> @@ -876,7 +876,7 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy,
>
>   	tegra_phy->pad_regs = devm_ioremap(&pdev->dev, res->start,
>   		resource_size(res));
> -	if (!tegra_phy->regs) {
> +	if (!tegra_phy->pad_regs) {
>   		dev_err(&pdev->dev, "Failed to remap UTMI Pad regs\n");
>   		return -ENOMEM;
>   	}

-- 
GTSYS Limited RFID Technology
A01 24/F Gold King Industrial Bld
35-41 Tai Lin Pai Road, Kwai Chung, Hong Kong
Fax (852) 8167 4060 - Tel (852) 3598 9488

Disclaimer: http://www.gtsys.com.hk/email/classified.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-04  2:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-04  2:00 [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI Chris Ruehl
2013-12-04  2:02 ` Chris Ruehl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®