mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
	MANAGEM..."  <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
	Srini Kandagatla <srinivas.kandagatla@linaro.org>,
	jank@cadence.com, Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [alsa-devel] [PATCH] soundwire: fix regmap dependencies and align with other serial links
Date: Wed, 7 Aug 2019 10:09:27 -0500	[thread overview]
Message-ID: <52a2cb0c-92a6-59d5-72da-832edd6481f3@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0g5Hk9JYLvRXfLk5-o=n_RVPKtWD=QONpiimCWyQOFELQ@mail.gmail.com>



On 7/19/19 4:04 AM, Rafael J. Wysocki wrote:
> On Fri, Jul 19, 2019 at 1:02 AM Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>>
>> The existing code has a mixed select/depend usage which makes no sense.
>>
>> config SOUNDWIRE_BUS
>>         tristate
>>         select REGMAP_SOUNDWIRE
>>
>> config REGMAP_SOUNDWIRE
>>          tristate
>>          depends on SOUNDWIRE_BUS
>>
>> Let's remove one layer of Kconfig definitions and align with the
>> solutions used by all other serial links.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> No issues found:
> 
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Vinod, Mark, any feedback?

There will be a set of SoundWire codec drivers provided upstream soonish 
and we'll get a number of kbuild errors without this patch.

> 
>> ---
>>   drivers/base/regmap/Kconfig | 2 +-
>>   drivers/soundwire/Kconfig   | 7 +------
>>   drivers/soundwire/Makefile  | 2 +-
>>   3 files changed, 3 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
>> index 6ad5ef48b61e..8cd2ac650b50 100644
>> --- a/drivers/base/regmap/Kconfig
>> +++ b/drivers/base/regmap/Kconfig
>> @@ -44,7 +44,7 @@ config REGMAP_IRQ
>>
>>   config REGMAP_SOUNDWIRE
>>          tristate
>> -       depends on SOUNDWIRE_BUS
>> +       depends on SOUNDWIRE
>>
>>   config REGMAP_SCCB
>>          tristate
>> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
>> index 3a01cfd70fdc..f518273cfbe3 100644
>> --- a/drivers/soundwire/Kconfig
>> +++ b/drivers/soundwire/Kconfig
>> @@ -4,7 +4,7 @@
>>   #
>>
>>   menuconfig SOUNDWIRE
>> -       bool "SoundWire support"
>> +       tristate "SoundWire support"
>>          help
>>            SoundWire is a 2-Pin interface with data and clock line ratified
>>            by the MIPI Alliance. SoundWire is used for transporting data
>> @@ -17,17 +17,12 @@ if SOUNDWIRE
>>
>>   comment "SoundWire Devices"
>>
>> -config SOUNDWIRE_BUS
>> -       tristate
>> -       select REGMAP_SOUNDWIRE
>> -
>>   config SOUNDWIRE_CADENCE
>>          tristate
>>
>>   config SOUNDWIRE_INTEL
>>          tristate "Intel SoundWire Master driver"
>>          select SOUNDWIRE_CADENCE
>> -       select SOUNDWIRE_BUS
>>          depends on X86 && ACPI && SND_SOC
>>          help
>>            SoundWire Intel Master driver.
>> diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile
>> index fd99a831b92a..45b7e5001653 100644
>> --- a/drivers/soundwire/Makefile
>> +++ b/drivers/soundwire/Makefile
>> @@ -5,7 +5,7 @@
>>
>>   #Bus Objs
>>   soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o
>> -obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o
>> +obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o
>>
>>   #Cadence Objs
>>   soundwire-cadence-objs := cadence_master.o
>> --
>> 2.20.1
>>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2019-08-07 15:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 23:02 Pierre-Louis Bossart
2019-07-19  9:04 ` Rafael J. Wysocki
2019-08-07 15:09   ` Pierre-Louis Bossart [this message]
2019-08-07 17:56     ` [alsa-devel] " Mark Brown
2019-08-07 18:17       ` Pierre-Louis Bossart
2019-08-07 19:09         ` Mark Brown
2019-08-08 13:48 ` Srinivas Kandagatla
2019-08-09  4:51 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52a2cb0c-92a6-59d5-72da-832edd6481f3@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jank@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sanyog.r.kale@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome