From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org,
vkoul@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com,
"Rafael J. Wysocki" <rafael@kernel.org>,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [PATCH] soundwire: fix regmap dependencies and align with other serial links
Date: Thu, 8 Aug 2019 14:48:28 +0100 [thread overview]
Message-ID: <8529d213-bfbb-780a-092d-3607eeb5e543@linaro.org> (raw)
In-Reply-To: <20190718230215.18675-1-pierre-louis.bossart@linux.intel.com>
On 19/07/2019 00:02, Pierre-Louis Bossart wrote:
> The existing code has a mixed select/depend usage which makes no sense.
>
> config SOUNDWIRE_BUS
> tristate
> select REGMAP_SOUNDWIRE
>
> config REGMAP_SOUNDWIRE
> tristate
> depends on SOUNDWIRE_BUS
>
> Let's remove one layer of Kconfig definitions and align with the
> solutions used by all other serial links.
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/base/regmap/Kconfig | 2 +-
> drivers/soundwire/Kconfig | 7 +------
> drivers/soundwire/Makefile | 2 +-
> 3 files changed, 3 insertions(+), 8 deletions(-)
I have been using some thing similar in my setup.
I did test this with Qualcomm WSA881x codec.
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
--srini
next prev parent reply other threads:[~2019-08-08 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 23:02 Pierre-Louis Bossart
2019-07-19 9:04 ` Rafael J. Wysocki
2019-08-07 15:09 ` [alsa-devel] " Pierre-Louis Bossart
2019-08-07 17:56 ` Mark Brown
2019-08-07 18:17 ` Pierre-Louis Bossart
2019-08-07 19:09 ` Mark Brown
2019-08-08 13:48 ` Srinivas Kandagatla [this message]
2019-08-09 4:51 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8529d213-bfbb-780a-092d-3607eeb5e543@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rafael@kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®