From: Markus Elfring <Markus.Elfring@web.de>
To: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Baruch Siach <baruch@tkos.co.il>,
Dejin Zheng <zhengdejin5@gmail.com>,
Dmitry Osipenko <digetx@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gregory Clement <gregory.clement@bootlin.com>,
Hans de Goede <hdegoede@redhat.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Pierre-Yves Mordret <pierre-yves.mordret@st.com>,
Thomas Gleixner <tglx@linutronix.de>,
Thor Thayer <thor.thayer@linux.intel.com>,
Vladimir Zapolskiy <vz@mleia.com>
Subject: Re: [PATCH] i2c: drivers: Remove superfluous error messages
Date: Mon, 4 May 2020 14:30:22 +0200 [thread overview]
Message-ID: <52dbb335-d3ea-3f14-8228-5832cfa59728@web.de> (raw)
> The function platform_get_irq can log an error by itself.
> This omit a redundant message for exception handling in the
> calling function.
I propose to avoid a typo in a word of this change description.
> Suggested by Coccinelle.
Can an information like the following be more helpful?
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
I observe that a command like “make COCCI=… M=drivers/i2c/busses/ coccicheck”
points only three source files out for further considerations
according to such a known transformation pattern in the software “Linux next-20200504”.
Regards,
Markus
next reply other threads:[~2020-05-04 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 12:30 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-04 12:30 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52dbb335-d3ea-3f14-8228-5832cfa59728@web.de \
--to=markus.elfring@web.de \
--cc=aishwaryarj100@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baruch@tkos.co.il \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-yves.mordret@st.com \
--cc=tglx@linutronix.de \
--cc=thor.thayer@linux.intel.com \
--cc=vz@mleia.com \
--cc=yamada.masahiro@socionext.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®